Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-11 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/ --- (Updated 2011-01-11 09:27:55.596573) Review request for Default, Ali Saidi, Gabe

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-11 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review722 --- Ship it! - Steve On 2011-01-11 09:27:55, Brad Beckmann wrote:

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/ --- (Updated 2011-01-10 15:59:13.160265) Review request for Default, Ali Saidi, Gabe

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Brad Beckmann
On 2011-01-10 13:54:18, Gabe Black wrote: src/mem/packet.hh, line 775 http://reviews.m5sim.org/r/399/diff/3/?file=9462#file9462line775 You need spaces around |. I can add a space around |, but hat is inconsistent with the rest of the file. - Brad

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review714 --- src/mem/ruby/system/RubyPort.cc

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review715 --- Ship it! Obviates the need for a different patch I had in my own queue,

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Gabe Black
On 2011-01-10 13:54:18, Gabe Black wrote: src/mem/packet.hh, line 775 http://reviews.m5sim.org/r/399/diff/3/?file=9462#file9462line775 You need spaces around |. Brad Beckmann wrote: I can add a space around |, but hat is inconsistent with the rest of the file. Ah, yeah, I