On 2011-01-07 04:45:16, Gabe Black wrote:
src/arch/x86/vtophys.cc, line 70
http://reviews.m5sim.org/r/385/diff/1/?file=9054#file9054line70
Having a temporary variable here seems unnecessary unless it's to
prevent having to wrap the next line. It's not a big deal, though.
Joel
src/arch/x86/vtophys.cchttp://reviews.m5sim.org/r/385/diff/1/?file=9054#file9054line70
(Diff
revision 1)
70
Fault fault = walker-startFunctional(tc, NULL, req, mode);
Having a temporary variable here seems unnecessary unless it's to prevent
having to wrap the next line.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/385/#review642
---
I think you forgot some files so this I suppose this is only a partial
On 2011-01-07 04:45:16, Gabe Black wrote:
I think you forgot some files so this I suppose this is only a partial
review. It looks like this could be cleanly split into three different
changes, and the fact that you have sub-commit messages for those
independent parts suggests that
On 2011-01-07 04:45:16, Gabe Black wrote:
src/arch/x86/vtophys.cc, line 58
http://reviews.m5sim.org/r/385/diff/1/?file=9054#file9054line58
Better wording might be Need access to page tables.
I like that change
On 2011-01-07 04:45:16, Gabe Black wrote:
src/arch/x86/vtophys.cc,
