[m5-dev] changeset in m5: This patch pulls out the auxiliary vector struc...

2008-12-05 Thread Lisa Hsu
changeset 9c3edb28db1a in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=9c3edb28db1a description: This patch pulls out the auxiliary vector struct from individual ISA LiveProcesses to the base LiveProcess definition so anyone can use them. diffstat: 5 files

Re: [m5-dev] changeset in m5: This patch pulls out the auxiliary vector struc...

2008-12-05 Thread Steve Reinhardt
Nice! I haven't looked at the code, but just based on this patch I have a couple of minor comments/questions: - What good does the union in the M5_auxv_t struct do if all the members are of the same type? It just seems a little odd to have a union just so we can refer to exactly the same thing

Re: [m5-dev] changeset in m5: This patch pulls out the auxiliary vector struc...

2008-12-05 Thread Lisa Hsu
Hey Steve, Actually, I didn't think about this part too much - I noticed Gabe had an aux struct within both the sparc and x86 namespaces, so i just pulled out without thinking about the basic design. The auxv_t struct is a standard struct, I think I actually saw definitions on the web saying the

Re: [m5-dev] changeset in m5: This patch pulls out the auxiliary vector struc...

2008-12-05 Thread Steve Reinhardt
Great. Thanks, guys. 2008/12/5 Lisa Hsu [EMAIL PROTECTED]: Awesome. I'll do that soon. Lisa On Fri, Dec 5, 2008 at 12:56 PM, [EMAIL PROTECTED] wrote: I'm actually ok with squishing the union. I put that in there to be semantically more in line with the original data type, but I don't