Re: [m5-dev] changeset in m5: flags: Provide an object for managing boolean f...

2008-11-14 Thread Gabe Black
I remember seeing some email about the names of the functions below, but I don't remember seeing anything about their correctness. Looking through the formulas here and making some assumptions about what they're trying to do, the following need to be fixed. bool all() const { return

Re: [m5-dev] changeset in m5: flags: Provide an object for managing boolean f...

2008-11-14 Thread Gabe Black
Also I notice that the flags aren't being copied over like the old bools used to be in the various constructors. I think the formulas below not working correctly were masking this bug. I recall someone else mentioning the assert in allocate causing them problems, and I can confirm it happened to

[m5-dev] changeset in m5: flags: Provide an object for managing boolean f...

2008-11-10 Thread Nathan Binkert
changeset f3733e2b19d5 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=f3733e2b19d5 description: flags: Provide an object for managing boolean flags for an object. In many cases it might be preferable to use bitset, but this object allows the user more