Re: [m5-dev] config patch

2009-09-12 Thread Polina Dudnik
On Fri, Sep 11, 2009 at 7:57 PM, nathan binkert n...@binkert.org wrote: I finally read this diff. My comments are inline. In the future, please use hg email which is found in the patchbomb extension. It makes it far easier to comment on diffs since I can just then reply to the e-mail

Re: [m5-dev] config patch

2009-09-11 Thread nathan binkert
I finally read this diff. My comments are inline. In the future, please use hg email which is found in the patchbomb extension. It makes it far easier to comment on diffs since I can just then reply to the e-mail without having to jump through hoops to get it into my mailer. Nate diff -r

Re: [m5-dev] config patch

2009-09-10 Thread Polina Dudnik
Nate, Did you get a chance to look at it? Thanks. Polina On Tue, Sep 1, 2009 at 9:30 AM, Nathan Binkert n...@binkert.org wrote: I will read it today. There are some issues. Please be a bit more patient. On Sep 1, 2009, at 8:15, Polina Dudnik pdud...@gmail.com wrote: I will push this if

Re: [m5-dev] config patch

2009-09-01 Thread Polina Dudnik
I will push this if nobody has any objections. On Mon, Aug 31, 2009 at 4:48 PM, Polina Dudnik pdud...@gmail.com wrote: Hi, I am attaching a small patch that enables the passing of the ruby config file as a parameter. So, multiple protocols can be tested without manually modifying the

Re: [m5-dev] config patch

2009-09-01 Thread Nathan Binkert
I will read it today. There are some issues. Please be a bit more patient. On Sep 1, 2009, at 8:15, Polina Dudnik pdud...@gmail.com wrote: I will push this if nobody has any objections. On Mon, Aug 31, 2009 at 4:48 PM, Polina Dudnik pdud...@gmail.com wrote: Hi, I am attaching a small

Re: [m5-dev] config patch

2009-09-01 Thread Polina Dudnik
Thank you. No rush. On Tue, Sep 1, 2009 at 9:30 AM, Nathan Binkert n...@binkert.org wrote: I will read it today. There are some issues. Please be a bit more patient. On Sep 1, 2009, at 8:15, Polina Dudnik pdud...@gmail.com wrote: I will push this if nobody has any objections. On Mon, Aug

[m5-dev] config patch

2009-08-31 Thread Polina Dudnik
Hi, I am attaching a small patch that enables the passing of the ruby config file as a parameter. So, multiple protocols can be tested without manually modifying the config_file name. Comments are welcome. Polina config_as_param Description: Binary data