Re: [m5-dev] m5: port: Clean up default port setup and port switchover code.

2008-06-16 Thread nathan binkert
I don't think this works, given that you've (still) got a single global static instance of DefaultPeerPort... right? I ask because this patch looks frighteningly familiar... I just did the same thing last week (including the identical class rename :-) ) but mine was more complicated because

Re: [m5-dev] m5: port: Clean up default port setup and port switchover code.

2008-06-16 Thread Steve Reinhardt
I was strictly talking about the port.cc changes... my diff doesn't touch base.cc, and I don't think it does much in port.hh either. So in that context, your answer seems to be no... Steve On Mon, Jun 16, 2008 at 11:33 AM, nathan binkert [EMAIL PROTECTED] wrote: Is there anything in your

Re: [m5-dev] m5: port: Clean up default port setup and port switchover code.

2008-06-15 Thread Steve Reinhardt
On Sun, Jun 15, 2008 at 9:37 PM, Nathan Binkert [EMAIL PROTECTED] wrote: changeset 758c2413765a in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=758c2413765a summary: port: Clean up default port setup and port switchover code. [...] diff -r 7c18f61da616 -r 758c2413765a