Re: [m5-dev] Review Request: Fix x86 XCHG macro-op to use locked micro-ops for all memory accesses

2010-07-21 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/59/#review99 --- This looks great. Thanks! - Gabe On 2010-07-20 17:05:54, Tushar Krishna

Re: [m5-dev] O3CPU + translateTiming

2010-07-21 Thread Min Kyu Jeong
so base_dyn_inst is always used timing memory - I assumed so but just wanted to confirm this to make sure that read function, BaseDynInstImpl::read(Addr addr, T data, unsigned flags) 'data' argument isn't really doing anything but being a placeholder for func sig matching in xc interface. -- is

[m5-dev] changeset in m5: Fix x86 XCHG macro-op to use locked micro-ops f...

2010-07-21 Thread Tushar Krishna
changeset a75564db03c3 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=a75564db03c3 description: Fix x86 XCHG macro-op to use locked micro-ops for all memory accesses diffstat: src/arch/x86/isa/insts/general_purpose/data_transfer/xchg.py | 16 ++-- 1 files

[m5-dev] Review Request: Power: The condition register should be set or cleared upon a system call

2010-07-21 Thread Timothy Jones
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/62/ --- Review request for Default. Summary --- Power: The condition register should

Re: [m5-dev] Review Request: Power: The condition register should be set or cleared upon a system call

2010-07-21 Thread Timothy Jones
On 2010-07-21 12:35:38, Ali Saidi wrote: src/arch/power/process.cc, line 289 http://reviews.m5sim.org/r/62/diff/1/?file=815#file815line289 Can this be a const or something as apposed to magical bit 28? Yes, no problem, I'll see what I can do. - Timothy

Re: [m5-dev] Review Request: Power: The condition register should be set or cleared upon a system call

2010-07-21 Thread Ali Saidi
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/62/#review102 --- Ship it! I'm happy. - Ali On 2010-07-21 13:14:02, Timothy Jones wrote:

[m5-dev] times syscall fix / ThreadContext suspension-reactivation

2010-07-21 Thread Ioannis Ilkos
Hello, I have been playing with time in m5 syscall emulation mode and had a couple of issues: First of all I believe there is a bug in the times() syscall implementation (sim/syscall_emul.hh). The current clocks value passed to the userland is: int64_t clocks = curTick *

[m5-dev] changeset in m5: stats: cleanup a few small problems in stats

2010-07-21 Thread Nathan Binkert
changeset ad631c296c9b in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=ad631c296c9b description: stats: cleanup a few small problems in stats diffstat: src/base/statistics.hh | 43 --- src/base/stats/text.cc | 16

[m5-dev] changeset in m5: stats: unify the two stats distribution type be...

2010-07-21 Thread Nathan Binkert
changeset 7772a8bf76ee in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=7772a8bf76ee description: stats: unify the two stats distribution type better diffstat: src/base/statistics.hh | 34 ++ src/base/stats/info.hh | 31