* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/o3-timing passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby
passed.
* build/ALPHA_SE/tests/fast/quick/20.eio-short/alpha/eio/simple-timing
passed.
*
On 2010-12-21 22:44:19, Steve Reinhardt wrote:
The name trace flags doesn't bother me, but debug flags is OK too. I
wouldn't want to be more generic than that though.
I was thinking of adding a command line option for --debug-flags, but leaving
the --trace-flags one there as well.
I think we really need some better documentation on the files is src/base.
They're supposed to be generic code that is used throughout M5, but I don't
even know what some of it does. Minimally, we should have doxgyen comments on
the files that describe what the code is trying to do, and
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/358/
---
Review request for Default.
Summary
---
The purpose of this patch is to
Hi Nilay,
The following protocols (all of which are tested by the regression tester)
should correctly work with the ruby random tester.
MOESI_CMP_directory
MOESI_hammer
MOESI_token
MI_example
Brad
-Original Message-
From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On
Yep that is the beauty of the random tester. It is much easier to fix problems
when you can reproduce them in 3 M cycles vs. 200 B.
Brad
-Original Message-
From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of
Nilay
Sent: Tuesday, December 21, 2010 8:00 PM
To:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/358/#review570
---
Hi Nilay,
Could you please include the changes to the
On 2010-12-21 22:44:19, Steve Reinhardt wrote:
The name trace flags doesn't bother me, but debug flags is OK too. I
wouldn't want to be more generic than that though.
Nathan Binkert wrote:
I was thinking of adding a command line option for --debug-flags, but
leaving the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/360/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
On 2010-12-21 22:30:11, Steve Reinhardt wrote:
src/base/debug.hh, line 38
http://reviews.m5sim.org/r/351/diff/1/?file=5592#file5592line38
It looks like we're not completely consistent on this, but I'd put the
close brace in column 0, then put the comment after that, e.g.:
On 2010-12-22 14:35:28, Brad Beckmann wrote:
Hi Nilay,
Could you please include the changes to the MOESI_CMP_directory protocol in
this patch? It is difficult to understand the ramifications of these changes
without seeing their impact to the .sm files. Also this is a very tricky patch
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/360/#review574
---
Ship it!
I only looked at a few. I hope that you don't expect anyone to
I don't have time to look at it right now, but I've attached the
directory that the error message is referring to.
On Wed, Dec 22, 2010 at 6:22 PM, Nilay Vaish ni...@cs.wisc.edu wrote:
Can some one try applying the attached diff? It touches only
src/mem/protocol/MOESI_CMP_directory-* files.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/359/
---
Review request for Default.
Summary
---
This is a request for reviewing the
changeset f249937228b5 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=f249937228b5
description:
This patch removes the WARN_* and ERROR_* from
src/mem/ruby/common/Debug.hh file. These statements have been replaced with
warn(), panic() and fatal() defined in
Apparently Review Board requires git-styled diffs.
On Wed, December 22, 2010 8:34 pm, nathan binkert wrote:
I don't have time to look at it right now, but I've attached the
directory that the error message is referring to.
On Wed, Dec 22, 2010 at 6:22 PM, Nilay Vaish ni...@cs.wisc.edu wrote:
16 matches
Mail list logo
