Re: [m5-dev] Object Initialization using Python

2011-03-10 Thread Nilay Vaish
Can you point out an example of vector parameter? That should serve my purpose. Thanks Nilay On Thu, 10 Mar 2011, nathan binkert wrote: As I understand, we use Python objects to initialize C++ objects. Is it possible to pass a pointer to an array (dynamic sized) from Python to C++? What do

Re: [m5-dev] Object Initialization using Python

2011-03-10 Thread Nilay Vaish
for VectorParam. Nate On Thu, Mar 10, 2011 at 3:55 PM, nathan binkert bink...@gmail.com wrote: I'm traveling so I don't have Access to code. Just grep for VectorParam On Mar 10, 2011, at 15:01, Nilay Vaish ni...@cs.wisc.edu wrote: Can you point out an example of vector parameter? That should

Re: [m5-dev] Functional Interface in Ruby

2011-03-09 Thread Nilay Vaish
What exactly happens on the function call Param.RubySystem(Parent.any, Ruby System) ? Nilay On Wed, 9 Mar 2011, Steve Reinhardt wrote: Does the RubySystem object have a pointer to a RubyCache object? You could also go into the python code and add some print statements to get a clue about

Re: [m5-dev] Functional Interface in Ruby

2011-03-09 Thread Nilay Vaish
Mar 2011, Steve Reinhardt wrote: I think you're looking in the wrong place... you want to look at getCCObject() in src/python/m5/SimObject.py where the error message is coming from, and see if you can add some print statements there. Steve On Wed, Mar 9, 2011 at 11:27 AM, Nilay Vaish ni

Re: [m5-dev] Functional Interface in Ruby

2011-03-08 Thread Nilay Vaish
into the Sequencer? It seems that the RubyPort would be a more natural location. Brad -Original Message- From: Nilay Vaish [mailto:ni...@cs.wisc.edu] Sent: Friday, March 04, 2011 9:49 AM To: Beckmann, Brad Cc: m5-dev@m5sim.org Subject: Functional Interface in Ruby I have been thinking about how

Re: [m5-dev] Functional Interface in Ruby

2011-03-08 Thread Nilay Vaish
each cache constructor call p-system-registerCache(this) to register itself Would something like this work for what you're trying to do? Steve On Tue, Mar 8, 2011 at 3:21 AM, Nilay Vaish ni...@cs.wisc.edu wrote: It seems that this will work out. We can make AbstractController call a static

Re: [m5-dev] Review Request: MOESI_hammer: cache flush support: Fix the deadlock issue, and Clean up the changed files

2011-03-08 Thread Nilay Vaish
Somayeh, there is an update option available in postreview. I think it is -u request number. You can use that to post update already created review requests. -- Nilay On Wed, 9 Mar 2011, Somayeh Sardashti wrote: --- This is an

[m5-dev] Adding data member to Sequencer

2011-03-07 Thread Nilay Vaish
Suppose I add a data member to the Sequencer class. How can I access this data member in configs/ruby/*.py? I am not able to figure out how the Python classes are related to the C++ classes. -- Nilay ___ m5-dev mailing list m5-dev@m5sim.org

[m5-dev] Review Request: SLICC: Remove external_type for structures

2011-03-04 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/534/ --- Review request for Default. Summary --- SLICC: Remove external_type for

[m5-dev] Functional Interface in Ruby

2011-03-04 Thread Nilay Vaish
I have been thinking about how to make Ruby support functional accesses. It seems some where we will have to add support so that either RubyPort or Sequencer can view all other caches. I am currently leaning towards adding it to the sequencer. I think this can be done by editing protocol files

[m5-dev] Review Request: Ruby: Add stall and wait to MESI CMP directory

2011-03-03 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/330/ --- Review request for Default. Summary --- This patch adds the stall and wait on

Re: [m5-dev] Review Request: Ruby: Add stall and wait to MESI CMP directory

2011-03-03 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/330/#review928 --- On 2011-03-03 09:20:38, Nilay Vaish wrote

[m5-dev] Review Request: Ruby: Fix DPRINTF bugs in PerfectSwitch and MessageBuffer

2011-03-01 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/505/ --- Review request for Default. Summary --- At a couple of places in

[m5-dev] changeset in m5: Ruby: Fix DPRINTF bugs in PerfectSwitch and Mes...

2011-03-01 Thread Nilay Vaish
changeset 2e1ee8ec6266 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=2e1ee8ec6266 description: Ruby: Fix DPRINTF bugs in PerfectSwitch and MessageBuffer At a couple of places in PerfectSwitch.cc and MessageBuffer.cc, DPRINTF() has not been provided

Re: [m5-dev] Functional Access support in Ruby

2011-02-26 Thread Nilay Vaish
. Nilay On Fri, 25 Feb 2011, Beckmann, Brad wrote: Yes, that is correct. The RubyPort::M5Port::recvFunctional() function is where we need to add the new support. Brad -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent

Re: [m5-dev] Functional Access support in Ruby

2011-02-26 Thread Nilay Vaish
-Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent: Saturday, February 26, 2011 9:06 AM To: M5 Developer List Subject: Re: [m5-dev] Functional Access support in Ruby I was thinking about the behavior of functional accesses. Currently

Re: [m5-dev] Functional Access support in Ruby

2011-02-26 Thread Nilay Vaish
. Nilay On Fri, 25 Feb 2011, Beckmann, Brad wrote: Yes, that is correct. The RubyPort::M5Port::recvFunctional() function is where we need to add the new support. Brad -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent: Friday

[m5-dev] Review Request: Ruby: Change DataBlock.hh

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/503/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: Ruby: Change Address.hh

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/504/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: Ruby: Remove libruby_internal.hh

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/506/ --- Review request for Default. Summary --- Ruby: Remove libruby_internal.hh This

Re: [m5-dev] Review Request: Ruby: Remove libruby

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/439/ --- (Updated 2011-02-25 08:32:18.235107) Review request for Default. Summary

[m5-dev] Review Request: Ruby: Remove store buffer

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/507/ --- Review request for Default. Summary --- Ruby: Remove store buffer This patch

Re: [m5-dev] Review Request: Ruby: Change DataBlock.hh

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/503/ --- (Updated 2011-02-25 08:34:04.928259) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Ruby: Make Address.hh independent of RubySystem

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/504/ --- (Updated 2011-02-25 10:51:09.206696) Review request for Default, Ali Saidi, Gabe

Re: [m5-dev] Review Request: Ruby: Make DataBlock.hh independent of RubySystem

2011-02-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/503/ --- (Updated 2011-02-25 10:51:51.189669) Review request for Default. Summary

Re: [m5-dev] Review Request: Ruby: Remove libruby_internal.hh

2011-02-25 Thread Nilay Vaish
. To reply, visit: http://reviews.m5sim.org/r/506/#review897 --- On 2011-02-25 08:30:30, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http

[m5-dev] Functional Access support in Ruby

2011-02-25 Thread Nilay Vaish
Brad, Here is my understanding of the current state of functional accesses in gem5. As of now, all functional accesses are forwarded to the PhysicalMemory's MemoryPort. Instead, we would like to add recvFunctional() function to M5Port of the RubyPort, and attach this port as peer instead of

[m5-dev] changeset in m5: Ruby: Make Address.hh independent of RubySystem

2011-02-25 Thread Nilay Vaish
changeset 04078b1214dd in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=04078b1214dd description: Ruby: Make Address.hh independent of RubySystem This patch changes Address.hh so that it is not dependent on RubySystem. This dependence seems unecessary. All

[m5-dev] changeset in m5: Ruby: Remove libruby

2011-02-25 Thread Nilay Vaish
changeset 6782b51ae8a8 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=6782b51ae8a8 description: Ruby: Remove libruby This patch removes libruby_internal.hh, libruby.hh and libruby.cc. It moves the contents to libruby.hh to RubyRequest.hh and

[m5-dev] changeset in m5: Ruby: Remove store buffer

2011-02-25 Thread Nilay Vaish
changeset 05a2f6ac1f8e in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=05a2f6ac1f8e description: Ruby: Remove store buffer This patch removes the store buffer from Ruby. It is not in use currently. Since libruby is being and store buffer makes calls to

Re: [m5-dev] Store Buffer

2011-02-24 Thread Nilay Vaish
On Thu, 24 Feb 2011, Arkaprava Basu wrote: Fundamentally, I wish to handle only non-speculative memory state within Ruby. Otherwise I think there might be risk of Ruby getting affected by the CPU model's behavior/nuances. As you suggested, Rubyport may well be the line dividing speculative

Re: [m5-dev] Store Buffer

2011-02-24 Thread Nilay Vaish
On Thu, 24 Feb 2011, Beckmann, Brad wrote: Steve, I think we are in agreement here and we may just be disagreeing with the definition of speculative. From the Ruby perspective, I don't think it really matters...I don't think there is difference between a speculative store address request and

[m5-dev] m5 wiki

2011-02-24 Thread Nilay Vaish
Can we impose restriction on the membership of the wiki? It seems that bogus pages are being created. For example -- http://m5sim.org/wiki/index.php/User:MiriamGSpeights -- Nilay ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] Review Request: ruby: automate permission setting

2011-02-23 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/496/#review882 --- Ship it! Overall the patch looks good to me.

Re: [m5-dev] Review Request: MOESI_hammer: cache probe address clean up

2011-02-23 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/495/#review883 --- Ship it! - Nilay On 2011-02-22 14:36:23, Brad Beckmann wrote:

Re: [m5-dev] Review Request: ruby: cleaned up access permission enum

2011-02-23 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/494/#review884 --- Ship it! - Nilay On 2011-02-22 14:36:31, Brad Beckmann wrote:

Re: [m5-dev] Review Request: ruby: extend dprintfs for RubyGenerated TraceFlag

2011-02-21 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/#review877 --- Ship it! - Nilay On 2011-02-18 14:55:40, Korey Sewell wrote:

[m5-dev] Error while pushing changes

2011-02-20 Thread Nilay Vaish
I am trying to push a couple of change sets, but I keep getting the following response remote: abort: No space left on device abort: unexpected response: empty string Can some one look into this? -- Nilay ___ m5-dev mailing list m5-dev@m5sim.org

[m5-dev] changeset in m5: Ruby: clean MOESI CMP directory protocol

2011-02-20 Thread Nilay Vaish
changeset 44f1ac4f587f in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=44f1ac4f587f description: Ruby: clean MOESI CMP directory protocol The L1 cache controller file contains references to foo and goo queues, which are not in use at all. These have been

[m5-dev] changeset in m5: Ruby: Machine Type missing in MOESI CMP directo...

2011-02-20 Thread Nilay Vaish
changeset 5e58eaf00b58 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=5e58eaf00b58 description: Ruby: Machine Type missing in MOESI CMP directory protocol In certain actions of the L1 cache controller, while creating an outgoing message, the machine

[m5-dev] Review Request: Ruby: clean MOESI CMP directory protocol

2011-02-18 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/490/ --- Review request for Default. Summary --- Ruby: clean MOESI CMP directory

Re: [m5-dev] Review Request: Ruby: clean MOESI CMP directory protocol

2011-02-18 Thread Nilay Vaish
generated e-mail. To reply, visit: http://reviews.m5sim.org/r/490/#review873 --- On 2011-02-18 06:01:20, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [m5-dev] CacheController's wakeup function

2011-02-17 Thread Nilay Vaish
and again. I need to look more closely at code generation for trigger(). -- Nilay -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent: Tuesday, February 15, 2011 9:09 AM To: M5 Developer List Subject: Re: [m5-dev

Re: [m5-dev] CacheController's wakeup function

2011-02-17 Thread Nilay Vaish
On Thu, 17 Feb 2011, Nilay Vaish wrote: On Wed, 16 Feb 2011, Beckmann, Brad wrote: Hi Nilay, I'm not quite sure what you mean by appended to while you drain, but I think you are asking whether the input ports will receive messages that are scheduled for the same cycle as the current cycle

[m5-dev] Profiling library and system calls

2011-02-16 Thread Nilay Vaish
I have noticed that when I profile GEM5 (in FS mode, or in SE using ruby random tester), the profile output accounts for about 1/4 to 1/3 of the time actually taken for the entire simulation. I think rest of the time is spent in system and library calls. Is there a way to profile these calls?

Re: [m5-dev] Incompleteness in MOESI_CMP_directory-L1cache.sm

2011-02-16 Thread Nilay Vaish
Can you email your patch, I'll take a look and commit the changes to the repository. Thanks! Nilay On Wed, 16 Feb 2011, Joseph Pusdesris wrote: Bump. -Joseph On Fri, Feb 11, 2011 at 3:28 PM, Joseph Pusdesris jo...@umich.edu wrote: I have noticed that many of the action definitions are

Re: [m5-dev] Incompleteness in MOESI_CMP_directory-L1cache.sm

2011-02-16 Thread Nilay Vaish
Sure! On Wed, 16 Feb 2011, Gabriel Michael Black wrote: Could you please use review board? I wouldn't know what I'm looking at, but other people might want a chance to look it over. Gabe Quoting Nilay Vaish ni...@cs.wisc.edu: Can you email your patch, I'll take a look and commit

Re: [m5-dev] Ruby: Recompiling SLICC

2011-02-16 Thread Nilay Vaish
On Wed, 16 Feb 2011, Korey Sewell wrote: Hi all, I noticed that on every build, SLICC wants to parse and generate C++/HTML on every compile regardless of any changes to code. The C++ part seems pretty quick, but the HTML portion hangs slightly. For the scons aficionados, how hard would it be

Re: [m5-dev] CacheController's wakeup function

2011-02-15 Thread Nilay Vaish
On Tue, 15 Feb 2011, nathan binkert wrote: While I don't know anything about this code it looks a little suspect to me. Is there really a while (true) or is there some sort of while (!empty)? Can the queues be appended to while you drain? If these are both true, then you'll lose some of your

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-14 Thread Nilay Vaish
Brad, this patch to affects the number of ticks required for performing a particular number of loads. I don't expect such a thing to happen. Do you? -- Nilay On Wed, 9 Feb 2011, Brad Beckmann wrote: --- This is an automatically

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-14 Thread Nilay Vaish
as before. -- Nilay On Mon, 14 Feb 2011, Nilay Vaish wrote: Brad, this patch to affects the number of ticks required for performing a particular number of loads. I don't expect such a thing to happen. Do you? -- Nilay On Wed, 9 Feb 2011, Brad Beckmann wrote

[m5-dev] changeset in m5: Ruby: Improve Change PerfectSwitch's wakeup fun...

2011-02-14 Thread Nilay Vaish
changeset e5550966464a in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=e5550966464a description: Ruby: Improve Change PerfectSwitch's wakeup function Currently the wakeup function for the PerfectSwitch contains three loops - loop on number of virtual

[m5-dev] Next steps

2011-02-14 Thread Nilay Vaish
Hi Brad, I have checked in the patch dealing with Perfect Switch. I am will clean the patch that removes CacheMsg class soon. What to take up next? I am kind of bored with this optimization stuff right now. -- Nilay ___ m5-dev mailing list

[m5-dev] CacheController's wakeup function

2011-02-14 Thread Nilay Vaish
I thought of this a moment ago, so I have not confirmed this empirically. The CacheController's wakeup function includes a while loop, in which all the queues are checked. Consider the Hammer protocol's L1 Cache Controller. It has four incoming queues - trigger, response, forward, mandatory.

[m5-dev] changeset in m5: Ruby: Reorder Cache Lookup in Protocol Files

2011-02-12 Thread Nilay Vaish
changeset e8f4bb35dca9 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=e8f4bb35dca9 description: Ruby: Reorder Cache Lookup in Protocol Files The patch changes the order in which L1 dcache and icache are looked up when a request comes in. Earlier, if a

[m5-dev] MOESI Hammer Protocol Deadlock

2011-02-10 Thread Nilay Vaish
Hi Brad, I think MOESI hammer protocol has a deadlock scenario. Try the following - hg update -r 7922 scons USE_MYSQL=False RUBY=True CC=gcc44 CXX=g++44 NO_HTML=True --no-colors build/ALPHA_SE_MOESI_hammer/m5.fast ./build/ALPHA_SE_MOESI_hammer/m5.fast ./configs/example/ruby_random_test.py

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-09 Thread Nilay Vaish
/328/#review839 --- On 2011-02-05 12:47:34, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/328

Re: [m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-09 Thread Nilay Vaish
On Wed, 9 Feb 2011, nathan binkert wrote: One simple nitpick before you commit is to fix the commit message so you put a proper summary line. Nate What would you like it to be? ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] changeset in m5: Ruby: Fixes MESI CMP directory protocol

2011-02-08 Thread Nilay Vaish
much. It will take bit more time of simulation to report the deadlock, but if there is an actual deadlock it would anyway report it. So I would vote to stick with Brad's threshold number in the patch. Thanks Arka On 02/07/2011 12:39 PM, Nilay Vaish wrote: Brad, I think 5,000,000 is a lot

[m5-dev] changeset in m5: MESI CMP: Unset TBE pointer in L2 cache controller

2011-02-08 Thread Nilay Vaish
changeset 9c245e375e05 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=9c245e375e05 description: MESI CMP: Unset TBE pointer in L2 cache controller The TBE pointer in the MESI CMP implementation was not being set to NULL when the TBE is deallocated. This

[m5-dev] Missing _ in ruby_fs.py

2011-02-08 Thread Nilay Vaish
Hi Brad, did you miss out on the '_' in _dma_devices? -- Nilay diff -r 6f5299ff8260 -r 00ad807ed2ca configs/example/ruby_fs.py --- a/configs/example/ruby_fs.pySun Feb 06 22:14:18 2011 -0800 +++ b/configs/example/ruby_fs.pySun Feb 06 22:14:18 2011 -0800 @@ -109,12 +109,19 @@

Re: [m5-dev] changeset in m5: Ruby: Fixes MESI CMP directory protocol

2011-02-07 Thread Nilay Vaish
then run the following command: build/ALPHA_SE_MESI_CMP_directory/m5.debug configs/example/ruby_mem_test.py -n 8 Let me know if you have any questions, Brad -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent: Thursday, January 13

Re: [m5-dev] changeset in m5: ruby: add stdio header in SRAM.hh

2011-02-07 Thread Nilay Vaish
Korey, I think the printf statements should be replaced with fatal() or panic() instead. -- Nilay On Mon, 7 Feb 2011, Korey Sewell wrote: changeset 5f2a2deb377d in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=5f2a2deb377d description: ruby: add stdio header in

Re: [m5-dev] changeset in m5: ruby: add stdio header in SRAM.hh

2011-02-07 Thread Nilay Vaish
it, but since he's in Singapore it is probably best that you or I do it. Thanks for pointing that out. Brad -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent: Monday, February 07, 2011 9:23 AM To: M5 Developer List Subject: Re: [m5

Re: [m5-dev] changeset in m5: Ruby: Fixes MESI CMP directory protocol

2011-02-07 Thread Nilay Vaish
simulation -Original Message- From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org] On Behalf Of Nilay Vaish Sent: Monday, February 07, 2011 9:12 AM To: M5 Developer List Subject: Re: [m5-dev] changeset in m5: Ruby: Fixes MESI CMP directory protocol Brad, I also see the protocol

[m5-dev] changeset in m5: Orion: Replace printf() with fatal()

2011-02-07 Thread Nilay Vaish
changeset 68f37178b408 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=68f37178b408 description: Orion: Replace printf() with fatal() The code for Orion 2.0 makes use of printf() at several places where there as an error in configuration of the model.

[m5-dev] Review Request: Ruby: Change PerfectSwitch's wakeup function

2011-02-05 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/328/ --- Review request for Default. Summary --- Currently the wakeup function for the

Re: [m5-dev] PerfectSwitch

2011-02-03 Thread Nilay Vaish
On Thu, 3 Feb 2011, Nilay Vaish wrote: I implemented this approach. But it did not improve the performance. So I tried to explore what could be the cause. The function PerfectSwitch::wakeup() contains three loops. loop on number of virtual networks loop on number of incoming links loop

Re: [m5-dev] PerfectSwitch

2011-02-03 Thread Nilay Vaish
Hi Brad, On Thu, 3 Feb 2011, Beckmann, Brad wrote: Hi Nilay, Yes, you could make such an optimization, but you want to be careful not to introduce starvation. You want to make sure that newly arriving messages are not always prioritized over previously stalled messages. Could you avoid

Re: [m5-dev] PerfectSwitch

2011-02-03 Thread Nilay Vaish
On Thu, 3 Feb 2011, Nilay Vaish wrote: Hi Brad, On Thu, 3 Feb 2011, Beckmann, Brad wrote: Hi Nilay, Yes, you could make such an optimization, but you want to be careful not to introduce starvation. You want to make sure that newly arriving messages are not always prioritized over

Re: [m5-dev] PerfectSwitch

2011-02-03 Thread Nilay Vaish
On Thu, 3 Feb 2011, Nilay Vaish wrote: On Thu, 3 Feb 2011, Nilay Vaish wrote: Hi Brad, On Thu, 3 Feb 2011, Beckmann, Brad wrote: Hi Nilay, Yes, you could make such an optimization, but you want to be careful not to introduce starvation. You want to make sure that newly arriving

Re: [m5-dev] PerfectSwitch

2011-02-03 Thread Nilay Vaish
On Thu, 3 Feb 2011, Nilay Vaish wrote: On Thu, 3 Feb 2011, Nilay Vaish wrote: On Thu, 3 Feb 2011, Nilay Vaish wrote: Hi Brad, On Thu, 3 Feb 2011, Beckmann, Brad wrote: Hi Nilay, Yes, you could make such an optimization, but you want to be careful not to introduce starvation. You want

Re: [m5-dev] mysql_version.h

2011-02-01 Thread Nilay Vaish
On Tue, 1 Feb 2011, Ali Saidi wrote: On Tue, 1 Feb 2011 06:14:24 -0600 (CST), Nilay Vaish ni...@cs.wisc.edu wrote: On Sun, 30 Jan 2011, nathan binkert wrote: We need a lot more details if we're going to help you. But I received an error that gcc could not find file. On Sat, January 29

[m5-dev] mysql_version.h

2011-01-29 Thread Nilay Vaish
The file src/base/mysql.hh includes mysql_version.h. Where all is it searched for? I think there you should be an initial check whether this file is with in the include path or not. -- Nilay ___ m5-dev mailing list m5-dev@m5sim.org

Re: [m5-dev] Profile Results for Mesh Network

2011-01-27 Thread Nilay Vaish
On Mon, 24 Jan 2011, Nilay Vaish wrote: On Mon, 24 Jan 2011, Steve Reinhardt wrote: Yes, that's right. So there's probably no big win in trying to further reduce the number of calls to lookup() in Ruby; the possibilities I see for improvement are: 1. Adding an instruction buffer to SimpleCPU

Re: [m5-dev] PerfectSwitch

2011-01-27 Thread Nilay Vaish
On Mon, 24 Jan 2011, Nilay Vaish wrote: On Tue, 18 Jan 2011, Beckmann, Brad wrote: Hi Nilay, My plan is to tackle the functional access support as soon as I check in our current group of outstanding patches. I'm hoping to at least check in the majority of them in the next couple of days

Re: [m5-dev] Profile Results for Mesh Network

2011-01-27 Thread Nilay Vaish
On Thu, 27 Jan 2011, Korey Sewell wrote: From Steve's response, it looks like I'm jumping in the conversation on the wrong page. To be clear, Nilay were you optimizing the lookup() calls or trying to reduce the number of times lookup gets called? My MRU comments and keeping things in the the

Re: [m5-dev] Profile Results for Mesh Network

2011-01-27 Thread Nilay Vaish
On Thu, 27 Jan 2011, Steve Reinhardt wrote: On Thu, Jan 27, 2011 at 4:36 AM, Nilay Vaish ni...@cs.wisc.edu wrote: I tried caching the index for the MRU block, so that the hash table need not be looked up. It is hard to point if there is a speed up or not. When I run m5.prof, profile results

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-01-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-25 09:15:23.221045) Review request for Default. Summary

[m5-dev] Review Request: Remove libruby

2011-01-25 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/439/ --- Review request for Default. Summary --- This patch removes libruby. It was

Re: [m5-dev] Review Request: Remove libruby

2011-01-25 Thread Nilay Vaish
--- On 2011-01-25 09:25:35, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/439/ --- (Updated 2011-01-25 09:25:35

Re: [m5-dev] Profile Results for Mesh Network

2011-01-24 Thread Nilay Vaish
On Mon, 24 Jan 2011, Steve Reinhardt wrote: On Sun, Jan 23, 2011 at 4:08 PM, Nilay Vaish ni...@cs.wisc.edu wrote: On Sun, 23 Jan 2011, Korey Sewell wrote: In sendFetch(), it calls sendTiming() which would then call the recvTiming on the cache port since those two should be binded as peers

[m5-dev] PerfectSwitch

2011-01-24 Thread Nilay Vaish
On Tue, 18 Jan 2011, Beckmann, Brad wrote: Hi Nilay, My plan is to tackle the functional access support as soon as I check in our current group of outstanding patches. I'm hoping to at least check in the majority of them in the next couple of days. Now that you've completed the

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-01-24 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-24 20:26:28.555420) Review request for Default. Summary

[m5-dev] Review Request: Ruby: Remove isTagPresent() calls from Sequencer.cc

2011-01-24 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/329/ --- Review request for Default. Summary --- Ruby: Remove isTagPresent() calls

Re: [m5-dev] Review Request: ruby: support to stallAndWait the mandatory queue

2011-01-23 Thread Nilay Vaish
On Sun, 23 Jan 2011, Beckmann, Brad wrote: Thanks Arka for that response. You summed it up well. There are just a couple additional things I want to point out: 1. One thing that makes this mechanism work is that one must rank each input port. In other words, the programmer must

Re: [m5-dev] Profile Results for Mesh Network

2011-01-23 Thread Nilay Vaish
I dug more in to the code today. There are three paths along which calls are made to the RubyPort::M5Port::recvTiming(), which eventually results in calls to CacheMemory::lookup(). 1. TimingSimpleCPU::sendFetch() - 140 million 2. TimingSimpleCPU::handleReadPacket() - 30 million 3.

Re: [m5-dev] Profile Results for Mesh Network

2011-01-23 Thread Nilay Vaish
(right now at least), but the relationship between sendTiming and recvTiming is the key concept that connects 2 memory objects unless things have changed. On Sun, Jan 23, 2011 at 3:51 PM, Nilay Vaish ni...@cs.wisc.edu wrote: I dug more in to the code today. There are three paths along which calls

Re: [m5-dev] Review Request: Ruby: Add support for locked memory accesses in X86_FS

2011-01-22 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/392/#review798 --- What's the difference between RMW and its locked version? I know that

Re: [m5-dev] Review Request: Ruby: Add support for locked memory accesses in X86_FS

2011-01-22 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/392/#review799 --- What's the difference between RMW and its locked version? I know that

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-01-21 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-21 05:03:54.622452) Review request for Default. Summary ---

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-01-21 Thread Nilay Vaish
/327/#review791 --- On 2011-01-21 05:03:54, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-01-21 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- (Updated 2011-01-21 05:19:07.165598) Review request for Default. Summary ---

Re: [m5-dev] Error in Simulating Mesh Network

2011-01-21 Thread Nilay Vaish
On Thu, Jan 20, 2011 at 8:15 AM, Nilay Vaish ni...@cs.wisc.edu wrote: Brad, I tried simulating a mesh network with four processors. ./build/ALPHA_FS_MOESI_hammer/m5.prof ./configs/example/ruby_fs.py --maxtick 2000 -n 4 --topology Mesh --mesh-rows 2 --num-l2cache 4 --num-dir 4 I receive

Re: [m5-dev] RefCountingPtr

2011-01-21 Thread Nilay Vaish
-0600, Nilay Vaish wrote: So how would you handle pointer to an object which is reference counted? Pointer to the same object may be being used at multiple places. I am facing some trouble with this. Should I post the code on the review board? Nilay On Thu, 20 Jan 2011, nathan binkert wrote

[m5-dev] Error in Simulating Mesh Network

2011-01-20 Thread Nilay Vaish
Brad, I tried simulating a mesh network with four processors. ./build/ALPHA_FS_MOESI_hammer/m5.prof ./configs/example/ruby_fs.py --maxtick 2000 -n 4 --topology Mesh --mesh-rows 2 --num-l2cache 4 --num-dir 4 I receive the following error: panic: FIFO ordering violated:

[m5-dev] RefCountingPtr

2011-01-20 Thread Nilay Vaish
What's the need of having reference counting? And more specifically, why do we need message going into ruby to be reference counted? Thanks Nilay ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] RefCountingPtr

2011-01-20 Thread Nilay Vaish
So how would you handle pointer to an object which is reference counted? Pointer to the same object may be being used at multiple places. I am facing some trouble with this. Should I post the code on the review board? Nilay On Thu, 20 Jan 2011, nathan binkert wrote: What's the need of

[m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-01-20 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327/ --- Review request for Default. Summary --- The goal of the patch is to do away

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-01-20 Thread Nilay Vaish
of the assertion on the request type. - Nilay On 2011-01-20 14:06:16, Nilay Vaish wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/327

<    1   2   3   4   >