Re: [gem5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-06-02 Thread Gabe Black

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/668/#review1294
---



SConstruct
http://reviews.m5sim.org/r/668/#comment1761

This is pretty reasonable, but it would be nice to mention that if it's not 
OK you can use Ctrl+C to get out of it. Usually Ctrl+C is a fairly drastic last 
resort, so people might not think to use it.


- Gabe


On 2011-06-01 21:27:23, Steve Reinhardt wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/668/
 ---
 
 (Updated 2011-06-01 21:27:23)
 
 
 Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
 Nathan Binkert.
 
 
 Summary
 ---
 
 SConstruct: automatically update .hg/hgrc with style hooks
 
 Seems easier than pestering people about it.
 Note also that path is now absolute, so you don't get errors
 when invoking hg from subdirectories.
 
 
 Diffs
 -
 
   SConstruct 3f49ed206f46 
 
 Diff: http://reviews.m5sim.org/r/668/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Steve
 


___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-06-02 Thread Steve Reinhardt


 On 2011-06-01 23:52:14, Gabe Black wrote:
  SConstruct, line 204
  http://reviews.m5sim.org/r/668/diff/2/?file=12773#file12773line204
 
  This is pretty reasonable, but it would be nice to mention that if it's 
  not OK you can use Ctrl+C to get out of it. Usually Ctrl+C is a fairly 
  drastic last resort, so people might not think to use it.

Yea, that crossed my mind... however, I still have the attitude that we're just 
informing the user about this change, not really asking permission, and the 
prompt is just there to make sure they see the notice. I'll try and make things 
a little clearer.


- Steve


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/668/#review1294
---


On 2011-06-01 21:27:23, Steve Reinhardt wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/668/
 ---
 
 (Updated 2011-06-01 21:27:23)
 
 
 Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
 Nathan Binkert.
 
 
 Summary
 ---
 
 SConstruct: automatically update .hg/hgrc with style hooks
 
 Seems easier than pestering people about it.
 Note also that path is now absolute, so you don't get errors
 when invoking hg from subdirectories.
 
 
 Diffs
 -
 
   SConstruct 3f49ed206f46 
 
 Diff: http://reviews.m5sim.org/r/668/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Steve
 


___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-06-01 Thread Steve Reinhardt

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/668/
---

(Updated 2011-06-01 21:27:23.466278)


Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

SConstruct: automatically update .hg/hgrc with style hooks

Seems easier than pestering people about it.
Note also that path is now absolute, so you don't get errors
when invoking hg from subdirectories.


Diffs (updated)
-

  SConstruct 3f49ed206f46 

Diff: http://reviews.m5sim.org/r/668/diff


Testing
---


Thanks,

Steve

___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-06-01 Thread Steve Reinhardt
Reviewboard didn't give me a chance to comment, but this is basically the
same as before except I now prompt for an input before modifying the
.hg/hgrc.  The truly paranoid can hit ctrl-c and get out of there.  I
thought it would be nice to get this in before the tutorial, since ideally
we'll have a bunch of newbies cloning new repositories.

Steve

On Wed, Jun 1, 2011 at 9:27 PM, Steve Reinhardt ste...@gmail.com wrote:

This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/668/
   Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and
 Nathan Binkert.
 By Steve Reinhardt.

 *Updated 2011-06-01 21:27:23.466278*
 Description

 SConstruct: automatically update .hg/hgrc with style hooks

 Seems easier than pestering people about it.
 Note also that path is now absolute, so you don't get errors
 when invoking hg from subdirectories.

   Diffs (updated)

- SConstruct (3f49ed206f46)

 View Diff http://reviews.m5sim.org/r/668/diff/

___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request: SConstruct: automatically update .hg/hgrc with style hooks

2011-06-01 Thread Ali Saidi

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/668/#review1293
---

Ship it!


- Ali


On 2011-06-01 21:27:23, Steve Reinhardt wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/668/
 ---
 
 (Updated 2011-06-01 21:27:23)
 
 
 Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
 Nathan Binkert.
 
 
 Summary
 ---
 
 SConstruct: automatically update .hg/hgrc with style hooks
 
 Seems easier than pestering people about it.
 Note also that path is now absolute, so you don't get errors
 when invoking hg from subdirectories.
 
 
 Diffs
 -
 
   SConstruct 3f49ed206f46 
 
 Diff: http://reviews.m5sim.org/r/668/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Steve
 


___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev