[gem5-dev] Review Request: config: tweak ruby configs to clean up hierarchy

2011-05-23 Thread Steve Reinhardt

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/709/
---

Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

config: tweak ruby configs to clean up hierarchy

Re-enabling implicit parenting (see previous patch) causes current
Ruby config scripts to create some strange hierarchies and generate
several warnings.  This patch makes three general changes to address
these issues.

1. The order of object creation in the ruby config files makes the L1
   caches children of the sequencer rather than the controller; these
   config ciles are rewritten to assign the L1 caches to the
   controller first.

2. The assignment of the sequencer list to system.ruby.cpu_ruby_ports
   causes the sequencers to be children of system.ruby, generating
   warnings because they are already parented to their respective
   controllers.  Changing this attribute to _cpu_ruby_ports fixes this
   because the leading underscore means this is now treated as a plain
   Python attribute rather than a child assignment. As a result, the
   configuration hierarchy changes such that, e.g.,
   system.ruby.cpu_ruby_ports0 becomes system.l1_cntrl0.sequencer.

3. In the topology classes, the routers become children of some random
   internal link node rather than direct children of the topology.
   The topology classes are rewritten to assign the routers to the
   topology object first.

[Note: the previous patch referred to above is http://reviews.m5sim.org/r/608 
,
which will be the previous patch when I commit these.]


Diffs
-

  configs/example/ruby_direct_test.py 7f106d0bd638 
  configs/example/ruby_fs.py 7f106d0bd638 
  configs/example/ruby_mem_test.py 7f106d0bd638 
  configs/example/ruby_network_test.py 7f106d0bd638 
  configs/example/ruby_random_test.py 7f106d0bd638 
  configs/example/se.py 7f106d0bd638 
  configs/ruby/MESI_CMP_directory.py 7f106d0bd638 
  configs/ruby/MI_example.py 7f106d0bd638 
  configs/ruby/MOESI_CMP_directory.py 7f106d0bd638 
  configs/ruby/MOESI_CMP_token.py 7f106d0bd638 
  configs/ruby/MOESI_hammer.py 7f106d0bd638 
  configs/ruby/Ruby.py 7f106d0bd638 
  src/mem/ruby/network/topologies/Crossbar.py 7f106d0bd638 
  src/mem/ruby/network/topologies/Mesh.py 7f106d0bd638 
  src/mem/ruby/network/topologies/MeshDirCorners.py 7f106d0bd638 
  src/mem/ruby/network/topologies/Pt2Pt.py 7f106d0bd638 
  src/mem/ruby/network/topologies/Torus.py 7f106d0bd638 
  tests/configs/memtest-ruby.py 7f106d0bd638 
  tests/configs/rubytest-ruby.py 7f106d0bd638 
  tests/configs/simple-timing-mp-ruby.py 7f106d0bd638 
  tests/configs/simple-timing-ruby.py 7f106d0bd638 

Diff: http://reviews.m5sim.org/r/709/diff


Testing
---


Thanks,

Steve

___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request: config: tweak ruby configs to clean up hierarchy

2011-05-23 Thread Tushar Krishna

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/709/#review1253
---


Hi Steve,
I think you will also have to make similar changes in 
configs/ruby/Network_test.py

-Tushar

- Tushar


On 2011-05-23 09:23:34, Steve Reinhardt wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/709/
 ---
 
 (Updated 2011-05-23 09:23:34)
 
 
 Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
 Nathan Binkert.
 
 
 Summary
 ---
 
 config: tweak ruby configs to clean up hierarchy
 
 Re-enabling implicit parenting (see previous patch) causes current
 Ruby config scripts to create some strange hierarchies and generate
 several warnings.  This patch makes three general changes to address
 these issues.
 
 1. The order of object creation in the ruby config files makes the L1
caches children of the sequencer rather than the controller; these
config ciles are rewritten to assign the L1 caches to the
controller first.
 
 2. The assignment of the sequencer list to system.ruby.cpu_ruby_ports
causes the sequencers to be children of system.ruby, generating
warnings because they are already parented to their respective
controllers.  Changing this attribute to _cpu_ruby_ports fixes this
because the leading underscore means this is now treated as a plain
Python attribute rather than a child assignment. As a result, the
configuration hierarchy changes such that, e.g.,
system.ruby.cpu_ruby_ports0 becomes system.l1_cntrl0.sequencer.
 
 3. In the topology classes, the routers become children of some random
internal link node rather than direct children of the topology.
The topology classes are rewritten to assign the routers to the
topology object first.
 
 [Note: the previous patch referred to above is 
 http://reviews.m5sim.org/r/608 ,
 which will be the previous patch when I commit these.]
 
 
 Diffs
 -
 
   configs/example/ruby_direct_test.py 7f106d0bd638 
   configs/example/ruby_fs.py 7f106d0bd638 
   configs/example/ruby_mem_test.py 7f106d0bd638 
   configs/example/ruby_network_test.py 7f106d0bd638 
   configs/example/ruby_random_test.py 7f106d0bd638 
   configs/example/se.py 7f106d0bd638 
   configs/ruby/MESI_CMP_directory.py 7f106d0bd638 
   configs/ruby/MI_example.py 7f106d0bd638 
   configs/ruby/MOESI_CMP_directory.py 7f106d0bd638 
   configs/ruby/MOESI_CMP_token.py 7f106d0bd638 
   configs/ruby/MOESI_hammer.py 7f106d0bd638 
   configs/ruby/Ruby.py 7f106d0bd638 
   src/mem/ruby/network/topologies/Crossbar.py 7f106d0bd638 
   src/mem/ruby/network/topologies/Mesh.py 7f106d0bd638 
   src/mem/ruby/network/topologies/MeshDirCorners.py 7f106d0bd638 
   src/mem/ruby/network/topologies/Pt2Pt.py 7f106d0bd638 
   src/mem/ruby/network/topologies/Torus.py 7f106d0bd638 
   tests/configs/memtest-ruby.py 7f106d0bd638 
   tests/configs/rubytest-ruby.py 7f106d0bd638 
   tests/configs/simple-timing-mp-ruby.py 7f106d0bd638 
   tests/configs/simple-timing-ruby.py 7f106d0bd638 
 
 Diff: http://reviews.m5sim.org/r/709/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Steve
 


___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev