Re: [m5-dev] [PATCH 3 of 3] O3PCU: Split loads and stores that cross cache line boundaries

2009-12-01 Thread Steve Reinhardt
Looking at just the part I've left below, it looks like you're separating out the split vs non-split calls at the top, and then they combine back into common functions at the bottom... I think it would be cleaner if we got rid of the separate calls, and just used NULL values for the split packets

[m5-dev] [PATCH 3 of 3] O3PCU: Split loads and stores that cross cache line boundaries

2009-11-09 Thread Timothy M. Jones
# HG changeset patch # User Timothy M. Jones tjon...@inf.ed.ac.uk # Date 1257772288 0 # Node ID 1c63ee4b8afa271d3ae645419e37913bbb97fe6b # Parent da27e67385cca6cf4dd6d18cdead5cfd54559afb O3PCU: Split loads and stores that cross cache line boundaries. When each load or store is sent to the LSQ,