Re: [m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread Gabe Black
Since we seem to have some folks using an older python, my vote would be
to make it 2.4 compatible. I don't have a good intuition about how old
2.4 is, though. If it's really ancient we might want to bump up the
required version and force Nilay (and anybody else) to upgrade.

Gabe

On 04/16/11 12:58, Steve Reinhardt wrote:
> Yea, if you look at the mentioned line, it's "mode = 'r+' if inplace
> else 'r'", and conditional assignments like this (basically python's
> version of C's "?:") weren't added until 2.5.  Since we officially
> only require python 2.4 (not 2.5), I'm happy to call this Nate's
> fault.  If you want to change the code to be 2.4 compatible you can,
> or you can upgrade your python, or you can just roll back to an
> earlier changeset in your local repo.
>
> Steve
>
> On Sat, Apr 16, 2011 at 12:10 PM, Nilay Vaish  wrote:
>> On Sat, 16 Apr 2011, nathan binkert wrote:
>>
>>> What version of python are you using?  It could be that that syntax
>>> wasn't available until 2.5 and you're using something older.  I can't
>>> do anything about it right now because I'm about to leave on a hike.
>>>
>>>  Nate
>>>
 Nate, it seems one of your checkins from yesterday has a bug. I receive
 the
 following message on executing any merculrial command.

 *** failed to import extension style from ./util/style.py: invalid syntax
 (file_types.py, line 143)


 --
 Nilay
>> I am using python version 2.4.3.
>>
>> Nilay
>> ___
>> m5-dev mailing list
>> m5-dev@m5sim.org
>> http://m5sim.org/mailman/listinfo/m5-dev
>>
> ___
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread Steve Reinhardt
Yea, if you look at the mentioned line, it's "mode = 'r+' if inplace
else 'r'", and conditional assignments like this (basically python's
version of C's "?:") weren't added until 2.5.  Since we officially
only require python 2.4 (not 2.5), I'm happy to call this Nate's
fault.  If you want to change the code to be 2.4 compatible you can,
or you can upgrade your python, or you can just roll back to an
earlier changeset in your local repo.

Steve

On Sat, Apr 16, 2011 at 12:10 PM, Nilay Vaish  wrote:
> On Sat, 16 Apr 2011, nathan binkert wrote:
>
>> What version of python are you using?  It could be that that syntax
>> wasn't available until 2.5 and you're using something older.  I can't
>> do anything about it right now because I'm about to leave on a hike.
>>
>>  Nate
>>
>>> Nate, it seems one of your checkins from yesterday has a bug. I receive
>>> the
>>> following message on executing any merculrial command.
>>>
>>> *** failed to import extension style from ./util/style.py: invalid syntax
>>> (file_types.py, line 143)
>>>
>>>
>>> --
>>> Nilay
>
> I am using python version 2.4.3.
>
> Nilay
> ___
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread Nilay Vaish

On Sat, 16 Apr 2011, nathan binkert wrote:


What version of python are you using?  It could be that that syntax
wasn't available until 2.5 and you're using something older.  I can't
do anything about it right now because I'm about to leave on a hike.

 Nate


Nate, it seems one of your checkins from yesterday has a bug. I receive the
following message on executing any merculrial command.

*** failed to import extension style from ./util/style.py: invalid syntax
(file_types.py, line 143)


--
Nilay


I am using python version 2.4.3.

Nilay
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread nathan binkert
What version of python are you using?  It could be that that syntax
wasn't available until 2.5 and you're using something older.  I can't
do anything about it right now because I'm about to leave on a hike.

  Nate

> Nate, it seems one of your checkins from yesterday has a bug. I receive the
> following message on executing any merculrial command.
>
> *** failed to import extension style from ./util/style.py: invalid syntax
> (file_types.py, line 143)
>
>
> --
> Nilay
> ___
> m5-dev mailing list
> m5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/m5-dev
>
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


[m5-dev] Bug in changeset 8225 or 8227

2011-04-16 Thread Nilay Vaish
Nate, it seems one of your checkins from yesterday has a bug. I receive 
the following message on executing any merculrial command.


*** failed to import extension style from ./util/style.py: invalid syntax 
(file_types.py, line 143)



--
Nilay
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev