Re: [m5-dev] Review Request: CPU: Remove references to memory copy operations
updated -or- disposed of. One is sufficient :-). Gabe On 03/30/11 13:13, Gabe Black wrote: > They're used in Checker and Ozone (and orthogonally overloaded in > InOrder it looks like). Checker and Ozone really need to be either > updated and disposed of, but until that happens I suppose it doesn't > make sense to make it worse -and- complicate these other two patches by > getting rid of the Results bits now. > > Gabe > > On 03/30/11 12:11, Gabe Black wrote: >> This does interact with Korey's change a bit, so hopefully we don't end >> up stepping on each other too much. Since somebody's going to have to >> update a patch anyway, I'll look at whether that result stuff in the >> dyninst can go away too. >> >> Gabe >> >> On 03/30/11 12:09, Gabe Black wrote: >>> --- >>> This is an automatically generated e-mail. To reply, visit: >>> http://reviews.m5sim.org/r/612/#review1035 >>> --- >>> >>> >>> Looks good to me. >>> >>> - Gabe >>> >>> >>> On 2011-03-30 08:58:56, Ali Saidi wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/612/ --- (Updated 2011-03-30 08:58:56) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- CPU: Remove references to memory copy operations Diffs - src/cpu/base_dyn_inst.hh d54b7775a6b0 src/cpu/inorder/inorder_dyn_inst.hh d54b7775a6b0 src/cpu/o3/commit_impl.hh d54b7775a6b0 src/cpu/ozone/lw_back_end_impl.hh d54b7775a6b0 src/cpu/static_inst.hh d54b7775a6b0 src/cpu/thread_state.hh d54b7775a6b0 Diff: http://reviews.m5sim.org/r/612/diff Testing --- Thanks, Ali >>> ___ >>> m5-dev mailing list >>> m5-dev@m5sim.org >>> http://m5sim.org/mailman/listinfo/m5-dev >> ___ >> m5-dev mailing list >> m5-dev@m5sim.org >> http://m5sim.org/mailman/listinfo/m5-dev > ___ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: CPU: Remove references to memory copy operations
They're used in Checker and Ozone (and orthogonally overloaded in InOrder it looks like). Checker and Ozone really need to be either updated and disposed of, but until that happens I suppose it doesn't make sense to make it worse -and- complicate these other two patches by getting rid of the Results bits now. Gabe On 03/30/11 12:11, Gabe Black wrote: > This does interact with Korey's change a bit, so hopefully we don't end > up stepping on each other too much. Since somebody's going to have to > update a patch anyway, I'll look at whether that result stuff in the > dyninst can go away too. > > Gabe > > On 03/30/11 12:09, Gabe Black wrote: >> --- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/612/#review1035 >> --- >> >> >> Looks good to me. >> >> - Gabe >> >> >> On 2011-03-30 08:58:56, Ali Saidi wrote: >>> --- >>> This is an automatically generated e-mail. To reply, visit: >>> http://reviews.m5sim.org/r/612/ >>> --- >>> >>> (Updated 2011-03-30 08:58:56) >>> >>> >>> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and >>> Nathan Binkert. >>> >>> >>> Summary >>> --- >>> >>> CPU: Remove references to memory copy operations >>> >>> >>> Diffs >>> - >>> >>> src/cpu/base_dyn_inst.hh d54b7775a6b0 >>> src/cpu/inorder/inorder_dyn_inst.hh d54b7775a6b0 >>> src/cpu/o3/commit_impl.hh d54b7775a6b0 >>> src/cpu/ozone/lw_back_end_impl.hh d54b7775a6b0 >>> src/cpu/static_inst.hh d54b7775a6b0 >>> src/cpu/thread_state.hh d54b7775a6b0 >>> >>> Diff: http://reviews.m5sim.org/r/612/diff >>> >>> >>> Testing >>> --- >>> >>> >>> Thanks, >>> >>> Ali >>> >>> >> ___ >> m5-dev mailing list >> m5-dev@m5sim.org >> http://m5sim.org/mailman/listinfo/m5-dev > ___ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: CPU: Remove references to memory copy operations
This does interact with Korey's change a bit, so hopefully we don't end up stepping on each other too much. Since somebody's going to have to update a patch anyway, I'll look at whether that result stuff in the dyninst can go away too. Gabe On 03/30/11 12:09, Gabe Black wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/612/#review1035 > --- > > > Looks good to me. > > - Gabe > > > On 2011-03-30 08:58:56, Ali Saidi wrote: >> --- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/612/ >> --- >> >> (Updated 2011-03-30 08:58:56) >> >> >> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and >> Nathan Binkert. >> >> >> Summary >> --- >> >> CPU: Remove references to memory copy operations >> >> >> Diffs >> - >> >> src/cpu/base_dyn_inst.hh d54b7775a6b0 >> src/cpu/inorder/inorder_dyn_inst.hh d54b7775a6b0 >> src/cpu/o3/commit_impl.hh d54b7775a6b0 >> src/cpu/ozone/lw_back_end_impl.hh d54b7775a6b0 >> src/cpu/static_inst.hh d54b7775a6b0 >> src/cpu/thread_state.hh d54b7775a6b0 >> >> Diff: http://reviews.m5sim.org/r/612/diff >> >> >> Testing >> --- >> >> >> Thanks, >> >> Ali >> >> > ___ > m5-dev mailing list > m5-dev@m5sim.org > http://m5sim.org/mailman/listinfo/m5-dev ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: CPU: Remove references to memory copy operations
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/612/#review1035 --- Looks good to me. - Gabe On 2011-03-30 08:58:56, Ali Saidi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/612/ > --- > > (Updated 2011-03-30 08:58:56) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > CPU: Remove references to memory copy operations > > > Diffs > - > > src/cpu/base_dyn_inst.hh d54b7775a6b0 > src/cpu/inorder/inorder_dyn_inst.hh d54b7775a6b0 > src/cpu/o3/commit_impl.hh d54b7775a6b0 > src/cpu/ozone/lw_back_end_impl.hh d54b7775a6b0 > src/cpu/static_inst.hh d54b7775a6b0 > src/cpu/thread_state.hh d54b7775a6b0 > > Diff: http://reviews.m5sim.org/r/612/diff > > > Testing > --- > > > Thanks, > > Ali > > ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
[m5-dev] Review Request: CPU: Remove references to memory copy operations
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/612/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- CPU: Remove references to memory copy operations Diffs - src/cpu/base_dyn_inst.hh d54b7775a6b0 src/cpu/inorder/inorder_dyn_inst.hh d54b7775a6b0 src/cpu/o3/commit_impl.hh d54b7775a6b0 src/cpu/ozone/lw_back_end_impl.hh d54b7775a6b0 src/cpu/static_inst.hh d54b7775a6b0 src/cpu/thread_state.hh d54b7775a6b0 Diff: http://reviews.m5sim.org/r/612/diff Testing --- Thanks, Ali ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
