Done.
Brad
-Original Message-
From: Nilay Vaish [mailto:ni...@cs.wisc.edu]
Sent: Tuesday, December 07, 2010 4:43 PM
To: Beckmann, Brad
Cc: Default
Subject: Re: Review Request: NDEBUG for Ruby Assert statement
Brad,
Since Steve and you have reviewed the patch, I guess we can commit it.
Brad,
Since Steve and you have reviewed the patch, I guess we can commit
it. I have one more patch in the queue.
Nilay
On Fri, 3 Dec 2010, Brad Beckmann wrote:
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/337/#review510
---
src/mem/ruby/common/Debug.hh
http://reviews.m5sim.org/r/337/#comment751
On 2010-12-06 15:56:33, Steve Reinhardt wrote:
src/mem/ruby/common/Debug.hh, line 146
http://reviews.m5sim.org/r/337/diff/2/?file=5442#file5442line146
What changed in these lines? I don't see any difference here. Was it
just a whitespace thing? If so, was it intentional?
I
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/337/#review515
---
Ship it!
- Steve
On 2010-12-02 20:35:31, Nilay Vaish wrote:
On 2010-12-06 15:56:33, Steve Reinhardt wrote:
src/mem/ruby/common/Debug.hh, line 146
http://reviews.m5sim.org/r/337/diff/2/?file=5442#file5442line146
What changed in these lines? I don't see any difference here. Was it
just a whitespace thing? If so, was it intentional?
I think the reason is that we would like to have the line numbers from the
.sm file. If we use ASSERT(), then the line numbers from the generated .cc
files will be put in place.
That makes sense, thanks...
Better would be to eventually make SLICC emit #file and #line directives.
Nate
That's what is going on right now.
Nilay
On Mon, December 6, 2010 10:16 pm, nathan binkert wrote:
I think the reason is that we would like to have the line numbers from
the .sm file. If we use ASSERT(), then the line numbers from the
generated .cc files will be put in place.
That makes
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/337/#review509
---
Ship it!
Looks good to me.
- Brad
On 2010-12-02 20:35:31, Nilay Vaish
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/337/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/337/
---
(Updated 2010-12-02 20:35:31.660861)
Review request for Default.
Summary
---
11 matches
Mail list logo