---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/336/
---
(Updated 2010-12-21 04:31:14.033111)
Review request for Default.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/336/#review545
---
Ship it!
Looks good to me, thanks for the changes!
- Steve
On
Nilay,
Can you push this commit as soon as you have time? This one should
definitely go in before my debug changes. I think this will also allow us
to completely get rid of the Debug class in Ruby.
Nate
On Tue, Dec 21, 2010 at 8:12 AM, Steve Reinhardt ste...@gmail.com wrote:
This is an
I don't have the commit access. Brad will have to do it for me. Or may be
you can.
--
Nilay
On Tue, 21 Dec 2010, nathan binkert wrote:
Nilay,
Can you push this commit as soon as you have time? This one should
definitely go in before my debug changes. I think this will also allow us
to
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/336/#review542
---
I second Nate: there's fatal() and panic() also take cprintf-style
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/336/#review540
---
You have a lot of fatals that I think should be panics. Ask Steve about
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/336/
---
(Updated 2010-12-19 12:02:55.605887)
Review request for Default.
Changes
---
On 2010-12-19 10:46:40, Nathan Binkert wrote:
You have a lot of fatals that I think should be panics. Ask Steve about
that. Also this diff didn't address my comments to your previous diff.
Steve, can you review this diff?
- Nilay
