Re: [m5-dev] Review Request: Ruby: Make Address.hh independent of RubySystem

2011-02-25 Thread Brad Beckmann

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/504/#review902
---

Ship it!


- Brad


On 2011-02-25 10:51:09, Nilay Vaish wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/504/
> ---
> 
> (Updated 2011-02-25 10:51:09)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> Ruby: Change Address.hh
> This patch changes Address.hh so that it is not dependent on RubySystem.
> This dependence seems unecessary. All those functions that depend on
> RubySystem have been moved to Address.cc file.
> 
> 
> Diffs
> -
> 
>   src/mem/ruby/common/Address.hh UNKNOWN 
>   src/mem/ruby/common/Address.cc UNKNOWN 
>   src/mem/ruby/filters/BlockBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/BulkBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/LSB_CountingBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/MultiGrainBloomFilter.cc UNKNOWN 
>   src/mem/ruby/filters/NonCountingBloomFilter.cc UNKNOWN 
> 
> Diff: http://reviews.m5sim.org/r/504/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nilay
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev


Re: [m5-dev] Review Request: Ruby: Make Address.hh independent of RubySystem

2011-02-25 Thread Nilay Vaish

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/504/
---

(Updated 2011-02-25 10:51:09.206696)


Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary (updated)
---

Ruby: Change Address.hh
This patch changes Address.hh so that it is not dependent on RubySystem.
This dependence seems unecessary. All those functions that depend on
RubySystem have been moved to Address.cc file.


Diffs
-

  src/mem/ruby/common/Address.hh UNKNOWN 
  src/mem/ruby/common/Address.cc UNKNOWN 
  src/mem/ruby/filters/BlockBloomFilter.cc UNKNOWN 
  src/mem/ruby/filters/BulkBloomFilter.cc UNKNOWN 
  src/mem/ruby/filters/LSB_CountingBloomFilter.cc UNKNOWN 
  src/mem/ruby/filters/MultiGrainBloomFilter.cc UNKNOWN 
  src/mem/ruby/filters/NonCountingBloomFilter.cc UNKNOWN 

Diff: http://reviews.m5sim.org/r/504/diff


Testing
---


Thanks,

Nilay

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev