Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-22 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/#review881 --- Ship it! - Brad On 2011-02-22 13:11:15, Korey Sewell wrote: > > --

Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-22 Thread Korey Sewell
OK, sorry for the double-update here... But I think this patch is ready to go. If/when it gets approved, I'll push the other ruby dprintf update patch ... On Tue, Feb 22, 2011 at 4:11 PM, Korey Sewell wrote: >This is an automatically generated e-mail. To reply, visit: > http://reviews.m5si

Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-22 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/ --- (Updated 2011-02-22 13:11:15.700425) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-22 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/ --- (Updated 2011-02-22 13:06:28.829795) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-22 Thread Nathan Binkert
> On 2011-02-18 13:33:14, Nathan Binkert wrote: > > src/mem/ruby/network/simple/Throttle.cc, line 253 > > > > > > ccprintf() > > Korey Sewell wrote: > In general, is it just a matter of preference or M5 style to do > {

Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-22 Thread Korey Sewell
> On 2011-02-18 13:33:14, Nathan Binkert wrote: > > src/mem/ruby/buffers/MessageBuffer.cc, line 58 > > > > > > How does the name get set now? This was an error, I shouldnt have taken this out. > On 2011-02-18 13:33:14, Nat

Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-18 Thread Nathan Binkert
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/#review875 --- src/mem/ruby/buffers/MessageBuffer.hh

Re: [m5-dev] Review Request: ruby: cleaning up RubyQueue and RubyNetwork dprintfs

2011-02-18 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/489/ --- (Updated 2011-02-18 09:18:43.750014) Review request for Default, Ali Saidi, Gabe Bl