Re: [m5-dev] Review Request: ruby: dbg: use system ticks instead of cycles
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/ --- (Updated 2011-04-15 10:33:39.285902) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: dbg: use system ticks instead of cycles It's easier to debug simulations (find the exact point to rerun a trace) when the output is in the system ticks instead of the Ruby cycle time Diffs (updated) - src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 src/mem/ruby/system/Sequencer.cc 54a65799e4c1 src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 src/mem/slicc/symbols/Type.py 54a65799e4c1 Diff: http://reviews.m5sim.org/r/635/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: dbg: use system ticks instead of cycles
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/#review1129 --- Ship it! Just a few minor alignment requests. Other than that, it looks good to me. src/mem/slicc/symbols/StateMachine.py http://reviews.m5sim.org/r/635/#comment1532 Since you're already modifying this DPRINTFR, can you align all the lines to the open paranethesis? Thanks src/mem/slicc/symbols/StateMachine.py http://reviews.m5sim.org/r/635/#comment1533 align here please src/mem/slicc/symbols/StateMachine.py http://reviews.m5sim.org/r/635/#comment1534 align here please - Brad On 2011-04-15 10:33:39, Korey Sewell wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/ --- (Updated 2011-04-15 10:33:39) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: dbg: use system ticks instead of cycles It's easier to debug simulations (find the exact point to rerun a trace) when the output is in the system ticks instead of the Ruby cycle time Diffs - src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 src/mem/ruby/system/Sequencer.cc 54a65799e4c1 src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 src/mem/slicc/symbols/Type.py 54a65799e4c1 Diff: http://reviews.m5sim.org/r/635/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: dbg: use system ticks instead of cycles
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/#review1104 --- Overall, this seems pretty straightforward. However I'm confused by the double curTick concerns. Specific comments below. src/mem/ruby/system/Sequencer.cc http://reviews.m5sim.org/r/635/#comment1473 If we are going to replace the cycle count with curTick(), then we should increase the width of that first field well beyond 7. Something like 15 makes sense to me. What do you think? Also I'm confused by Nilay's concern about printing out the curTick twice. DPRINTFR doesn't print out the curTick by default, correct? Therefore the current tick will only be printed once. src/mem/ruby/system/Sequencer.cc http://reviews.m5sim.org/r/635/#comment1474 Same thing here. Increase first field well beyond 7. src/mem/slicc/symbols/StateMachine.py http://reviews.m5sim.org/r/635/#comment1475 beyond 7 src/mem/slicc/symbols/StateMachine.py http://reviews.m5sim.org/r/635/#comment1476 beyond 7 src/mem/slicc/symbols/StateMachine.py http://reviews.m5sim.org/r/635/#comment1477 beyond 7 - Brad On 2011-04-05 11:19:26, Korey Sewell wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/ --- (Updated 2011-04-05 11:19:26) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: dbg: use system ticks instead of cycles It's easier to debug simulations (find the exact point to rerun a trace) when the output is in the system ticks instead of the Ruby cycle time Diffs - src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 src/mem/ruby/system/Sequencer.cc 54a65799e4c1 src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 src/mem/slicc/symbols/Type.py 54a65799e4c1 Diff: http://reviews.m5sim.org/r/635/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: dbg: use system ticks instead of cycles
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/#review1102 --- src/mem/ruby/network/simple/PerfectSwitch.cc http://reviews.m5sim.org/r/635/#comment1467 If DPRINTF() prints the time, is this piece of code required? src/mem/ruby/system/Sequencer.cc http://reviews.m5sim.org/r/635/#comment1468 Again, do we need curTick() here? src/mem/ruby/system/Sequencer.cc http://reviews.m5sim.org/r/635/#comment1469 Same comment as before. - Nilay On 2011-04-05 11:19:26, Korey Sewell wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/ --- (Updated 2011-04-05 11:19:26) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: dbg: use system ticks instead of cycles It's easier to debug simulations (find the exact point to rerun a trace) when the output is in the system ticks instead of the Ruby cycle time Diffs - src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 src/mem/ruby/system/Sequencer.cc 54a65799e4c1 src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 src/mem/slicc/symbols/Type.py 54a65799e4c1 Diff: http://reviews.m5sim.org/r/635/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: dbg: use system ticks instead of cycles
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/#review1103 --- src/mem/ruby/network/simple/PerfectSwitch.cc http://reviews.m5sim.org/r/635/#comment1472 You are probably right here. No need to print out the time 2x. A slightly different scenario for DPRINTFRs though. src/mem/ruby/system/Sequencer.cc http://reviews.m5sim.org/r/635/#comment1470 DPRINTFR doesnt print the tick, but DPRINTF does print the tick. curTick() is needed here. src/mem/ruby/system/Sequencer.cc http://reviews.m5sim.org/r/635/#comment1471 Ditto about DPRINTFR which doesnt automatically print out the ticks for you. - Korey On 2011-04-05 11:19:26, Korey Sewell wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/ --- (Updated 2011-04-05 11:19:26) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: dbg: use system ticks instead of cycles It's easier to debug simulations (find the exact point to rerun a trace) when the output is in the system ticks instead of the Ruby cycle time Diffs - src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 src/mem/ruby/system/Sequencer.cc 54a65799e4c1 src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 src/mem/slicc/symbols/Type.py 54a65799e4c1 Diff: http://reviews.m5sim.org/r/635/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
[m5-dev] Review Request: ruby: dbg: use system ticks instead of cycles
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/635/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: dbg: use system ticks instead of cycles It's easier to debug simulations (find the exact point to rerun a trace) when the output is in the system ticks instead of the Ruby cycle time Diffs - src/mem/ruby/buffers/MessageBuffer.cc 54a65799e4c1 src/mem/ruby/network/simple/PerfectSwitch.cc 54a65799e4c1 src/mem/ruby/system/Sequencer.cc 54a65799e4c1 src/mem/slicc/symbols/StateMachine.py 54a65799e4c1 src/mem/slicc/symbols/Type.py 54a65799e4c1 Diff: http://reviews.m5sim.org/r/635/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev