Re: [m5-dev] Review Request: ruby: extend dprintfs for RubyGenerated TraceFlag
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/#review877 --- Ship it! - Nilay On 2011-02-18 14:55:40, Korey Sewell wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/ --- (Updated 2011-02-18 14:55:40) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: extend dprintfs for RubyGenerated TraceFlag executing isnt a very descriptive debug message and in going through the output you get multiple messages that say executing but nothing to help you parse through the code/execution. So instead, at least print out the name of the action that is taking place in these functions. Diffs - src/mem/slicc/symbols/StateMachine.py bb35cb393bbb Diff: http://reviews.m5sim.org/r/492/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: extend dprintfs for RubyGenerated TraceFlag
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/#review878 --- Ship it! - Brad On 2011-02-18 14:55:40, Korey Sewell wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/ --- (Updated 2011-02-18 14:55:40) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: extend dprintfs for RubyGenerated TraceFlag executing isnt a very descriptive debug message and in going through the output you get multiple messages that say executing but nothing to help you parse through the code/execution. So instead, at least print out the name of the action that is taking place in these functions. Diffs - src/mem/slicc/symbols/StateMachine.py bb35cb393bbb Diff: http://reviews.m5sim.org/r/492/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: extend dprintfs for RubyGenerated TraceFlag
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/#review876 --- Looks like a good idea to me. Can any ruby people OK this for Korey? - Nathan On 2011-02-18 14:55:40, Korey Sewell wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/ --- (Updated 2011-02-18 14:55:40) Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: extend dprintfs for RubyGenerated TraceFlag executing isnt a very descriptive debug message and in going through the output you get multiple messages that say executing but nothing to help you parse through the code/execution. So instead, at least print out the name of the action that is taking place in these functions. Diffs - src/mem/slicc/symbols/StateMachine.py bb35cb393bbb Diff: http://reviews.m5sim.org/r/492/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
[m5-dev] Review Request: ruby: extend dprintfs for RubyGenerated TraceFlag
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/492/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: extend dprintfs for RubyGenerated TraceFlag executing isnt a very descriptive debug message and in going through the output you get multiple messages that say executing but nothing to help you parse through the code/execution. So instead, at least print out the name of the action that is taking place in these functions. Diffs - src/mem/slicc/symbols/StateMachine.py bb35cb393bbb Diff: http://reviews.m5sim.org/r/492/diff Testing --- Thanks, Korey ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
