Re: [m5-dev] Review Request: ruby: moved topology to the top network directory
> On 2011-04-23 20:36:40, Nathan Binkert wrote: > > Did you use hg mv? The diff doesn't seem to include that information, > > though maybe reviewboard whacks that. Yes, I did. diff --git a/src/mem/ruby/network/simple/Topology.cc b/src/mem/ruby/network/Topology.cc rename from src/mem/ruby/network/simple/Topology.cc rename to src/mem/ruby/network/Topology.cc --- a/src/mem/ruby/network/simple/Topology.cc +++ b/src/mem/ruby/network/Topology.cc - Brad --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/651/#review1147 --- On 2011-04-22 15:16:44, Brad Beckmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/651/ > --- > > (Updated 2011-04-22 15:16:44) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > ruby: moved topology to the top network directory > > Moved the Topology class to the top network directory because it is shared by > both the simple and Garnet networks. > > > Diffs > - > > src/mem/ruby/network/Network.cc 914389024c33 > src/mem/ruby/network/SConscript 914389024c33 > src/mem/ruby/network/Topology.hh PRE-CREATION > src/mem/ruby/network/Topology.cc PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 914389024c33 > src/mem/ruby/network/simple/SConscript 914389024c33 > src/mem/ruby/network/simple/SimpleNetwork.cc 914389024c33 > src/mem/ruby/network/simple/Topology.hh 914389024c33 > src/mem/ruby/network/simple/Topology.cc 914389024c33 > > Diff: http://reviews.m5sim.org/r/651/diff > > > Testing > --- > > > Thanks, > > Brad > > ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: moved topology to the top network directory
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/651/#review1147 --- Did you use hg mv? The diff doesn't seem to include that information, though maybe reviewboard whacks that. - Nathan On 2011-04-22 15:16:44, Brad Beckmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/651/ > --- > > (Updated 2011-04-22 15:16:44) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > ruby: moved topology to the top network directory > > Moved the Topology class to the top network directory because it is shared by > both the simple and Garnet networks. > > > Diffs > - > > src/mem/ruby/network/Network.cc 914389024c33 > src/mem/ruby/network/SConscript 914389024c33 > src/mem/ruby/network/Topology.hh PRE-CREATION > src/mem/ruby/network/Topology.cc PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 914389024c33 > src/mem/ruby/network/simple/SConscript 914389024c33 > src/mem/ruby/network/simple/SimpleNetwork.cc 914389024c33 > src/mem/ruby/network/simple/Topology.hh 914389024c33 > src/mem/ruby/network/simple/Topology.cc 914389024c33 > > Diff: http://reviews.m5sim.org/r/651/diff > > > Testing > --- > > > Thanks, > > Brad > > ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] Review Request: ruby: moved topology to the top network directory
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/651/#review1146 --- Did you use hg mv? The diff doesn't seem to include that information, though maybe reviewboard whacks that. - Nathan On 2011-04-22 15:16:44, Brad Beckmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/651/ > --- > > (Updated 2011-04-22 15:16:44) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > --- > > ruby: moved topology to the top network directory > > Moved the Topology class to the top network directory because it is shared by > both the simple and Garnet networks. > > > Diffs > - > > src/mem/ruby/network/Network.cc 914389024c33 > src/mem/ruby/network/SConscript 914389024c33 > src/mem/ruby/network/Topology.hh PRE-CREATION > src/mem/ruby/network/Topology.cc PRE-CREATION > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 914389024c33 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 914389024c33 > src/mem/ruby/network/simple/SConscript 914389024c33 > src/mem/ruby/network/simple/SimpleNetwork.cc 914389024c33 > src/mem/ruby/network/simple/Topology.hh 914389024c33 > src/mem/ruby/network/simple/Topology.cc 914389024c33 > > Diff: http://reviews.m5sim.org/r/651/diff > > > Testing > --- > > > Thanks, > > Brad > > ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
[m5-dev] Review Request: ruby: moved topology to the top network directory
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/651/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binkert. Summary --- ruby: moved topology to the top network directory Moved the Topology class to the top network directory because it is shared by both the simple and Garnet networks. Diffs - src/mem/ruby/network/Network.cc 914389024c33 src/mem/ruby/network/SConscript 914389024c33 src/mem/ruby/network/Topology.hh PRE-CREATION src/mem/ruby/network/Topology.cc PRE-CREATION src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc 914389024c33 src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc 914389024c33 src/mem/ruby/network/simple/SConscript 914389024c33 src/mem/ruby/network/simple/SimpleNetwork.cc 914389024c33 src/mem/ruby/network/simple/Topology.hh 914389024c33 src/mem/ruby/network/simple/Topology.cc 914389024c33 Diff: http://reviews.m5sim.org/r/651/diff Testing --- Thanks, Brad ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
