Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-12 Thread Ali Saidi 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/689/#review1231
---

Ship it!


- Ali


On 2011-05-10 06:08:21, Nathan Binkert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/689/
> ---
> 
> (Updated 2011-05-10 06:08:21)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> stats: better expose statistics to python.
> Build a python list and dict of all stats and expose flags properly.
> 
> 
> Diffs
> -
> 
>   src/python/SConscript 44f8c2507d85 
>   src/python/m5/stats.py 44f8c2507d85 
>   src/python/m5/stats/__init__.py PRE-CREATION 
>   src/python/swig/stats.i 44f8c2507d85 
> 
> Diff: http://reviews.m5sim.org/r/689/diff
> 
> 
> Testing
> ---
> 
> quick regressions pass (though most recently run with review 690 and 691)
> 
> 
> Thanks,
> 
> Nathan
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert 


> On 2011-05-10 15:19:06, Ali Saidi wrote:
> > src/python/m5/stats/__init__.py, line 29
> > 
> >
> > Please add a this file does comment... e.g. This file provides 
> > accessors to all the m5 stats or something..

Actually, this file isn't new.  It's the result of a rename.  I'll try to add 
documentation nearer the end of all of these changes.


- Nathan


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/689/#review1221
---


On 2011-05-10 06:08:21, Nathan Binkert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/689/
> ---
> 
> (Updated 2011-05-10 06:08:21)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> stats: better expose statistics to python.
> Build a python list and dict of all stats and expose flags properly.
> 
> 
> Diffs
> -
> 
>   src/python/SConscript 44f8c2507d85 
>   src/python/m5/stats.py 44f8c2507d85 
>   src/python/m5/stats/__init__.py PRE-CREATION 
>   src/python/swig/stats.i 44f8c2507d85 
> 
> Diff: http://reviews.m5sim.org/r/689/diff
> 
> 
> Testing
> ---
> 
> quick regressions pass (though most recently run with review 690 and 691)
> 
> 
> Thanks,
> 
> Nathan
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-12 Thread Nathan Binkert 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/689/#review1228
---



src/python/m5/stats/__init__.py


Actually, this is fixed in the subsequent diff.  This code is already in 
the tree and was just part of the rename from stats.py to stats/__init__.py


- Nathan


On 2011-05-10 06:08:21, Nathan Binkert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/689/
> ---
> 
> (Updated 2011-05-10 06:08:21)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> stats: better expose statistics to python.
> Build a python list and dict of all stats and expose flags properly.
> 
> 
> Diffs
> -
> 
>   src/python/SConscript 44f8c2507d85 
>   src/python/m5/stats.py 44f8c2507d85 
>   src/python/m5/stats/__init__.py PRE-CREATION 
>   src/python/swig/stats.i 44f8c2507d85 
> 
> Diff: http://reviews.m5sim.org/r/689/diff
> 
> 
> Testing
> ---
> 
> quick regressions pass (though most recently run with review 690 and 691)
> 
> 
> Thanks,
> 
> Nathan
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-11 Thread Nathan Binkert 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/689/#review1227
---



src/python/m5/stats/__init__.py


yeah, yeah.



src/python/m5/stats/__init__.py


good point.


- Nathan


On 2011-05-10 06:08:21, Nathan Binkert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/689/
> ---
> 
> (Updated 2011-05-10 06:08:21)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> stats: better expose statistics to python.
> Build a python list and dict of all stats and expose flags properly.
> 
> 
> Diffs
> -
> 
>   src/python/SConscript 44f8c2507d85 
>   src/python/m5/stats.py 44f8c2507d85 
>   src/python/m5/stats/__init__.py PRE-CREATION 
>   src/python/swig/stats.i 44f8c2507d85 
> 
> Diff: http://reviews.m5sim.org/r/689/diff
> 
> 
> Testing
> ---
> 
> quick regressions pass (though most recently run with review 690 and 691)
> 
> 
> Thanks,
> 
> Nathan
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: stats: better expose statistics to python.

2011-05-10 Thread Ali Saidi 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/689/#review1221
---



src/python/m5/stats/__init__.py


Please add a this file does comment... e.g. This file provides accessors to 
all the m5 stats or something..



src/python/m5/stats/__init__.py


Is this true given that prepare is commented out?


- Ali


On 2011-05-10 06:08:21, Nathan Binkert wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/689/
> ---
> 
> (Updated 2011-05-10 06:08:21)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> stats: better expose statistics to python.
> Build a python list and dict of all stats and expose flags properly.
> 
> 
> Diffs
> -
> 
>   src/python/SConscript 44f8c2507d85 
>   src/python/m5/stats.py 44f8c2507d85 
>   src/python/m5/stats/__init__.py PRE-CREATION 
>   src/python/swig/stats.i 44f8c2507d85 
> 
> Diff: http://reviews.m5sim.org/r/689/diff
> 
> 
> Testing
> ---
> 
> quick regressions pass (though most recently run with review 690 and 691)
> 
> 
> Thanks,
> 
> Nathan
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] Review Request: stats: better expose statistics to python.

2011-05-10 Thread Nathan Binkert 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/689/
---

Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan 
Binkert.


Summary
---

stats: better expose statistics to python.
Build a python list and dict of all stats and expose flags properly.


Diffs
-

  src/python/SConscript 44f8c2507d85 
  src/python/m5/stats.py 44f8c2507d85 
  src/python/m5/stats/__init__.py PRE-CREATION 
  src/python/swig/stats.i 44f8c2507d85 

Diff: http://reviews.m5sim.org/r/689/diff


Testing
---

quick regressions pass (though most recently run with review 690 and 691)


Thanks,

Nathan

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev