Re: [m5-dev] changeset in m5: build: fix compiler warnings in g++ 3.4
nathan binkert wrote: Seems like it would be worth setting up a slew of g++ revs on zizzer and running regressions under all of them, maybe on a rotating basis... Yeah, I agree. Multiple revs of swig and maybe scons would be good too. I think we should set up a separate compile everything regression actually. It doesn't take that long to compile the tree, and with the pool being available, we could just compile a bunch of combinations. Nate ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev This sounds like a good idea, and I think as long as we compile under the different versions we'll get 95% of the benefit. I think any difference in correctness of execution would be very unlikely, so running the regressions themselves more than once would probably not be worth the effort. Maybe a rotation like you suggested would hit all the variations often enough that if it -does- happen then we'll catch it eventually. Gabe ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
[m5-dev] changeset in m5: build: fix compiler warnings in g++ 3.4
changeset 74bc713c71ce in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=74bc713c71ce
description:
build: fix compiler warnings in g++ 3.4
diffstat:
1 file changed, 11 insertions(+), 11 deletions(-)
src/arch/x86/faults.hh | 22 +++---
diffs (60 lines):
diff -r fb50ea61a226 -r 74bc713c71ce src/arch/x86/faults.hh
--- a/src/arch/x86/faults.hhSat Mar 07 17:24:13 2009 -0800
+++ b/src/arch/x86/faults.hhSat Mar 07 21:34:50 2009 -0800
@@ -76,9 +76,9 @@
uint64_t errorCode;
X86FaultBase(const char * _faultName, const char * _mnem,
-const uint8_t _vector, uint64_t _errorCode = -1) :
-faultName(_faultName), mnem(_mnem),
-vector(_vector), errorCode(_errorCode)
+ const uint8_t _vector, uint64_t _errorCode = (uint64_t)-1)
+: faultName(_faultName), mnem(_mnem),
+ vector(_vector), errorCode(_errorCode)
{
}
@@ -115,8 +115,8 @@
{
protected:
X86Fault(const char * name, const char * mnem,
-const uint8_t vector, uint64_t _errorCode = -1) :
-X86FaultBase(name, mnem, vector, _errorCode)
+ const uint8_t vector, uint64_t _errorCode = (uint64_t)-1)
+: X86FaultBase(name, mnem, vector, _errorCode)
{}
};
@@ -126,8 +126,8 @@
{
protected:
X86Trap(const char * name, const char * mnem,
-const uint8_t vector, uint64_t _errorCode = -1) :
-X86FaultBase(name, mnem, vector, _errorCode)
+const uint8_t vector, uint64_t _errorCode = (uint64_t)-1)
+: X86FaultBase(name, mnem, vector, _errorCode)
{}
#if FULL_SYSTEM
@@ -140,8 +140,8 @@
{
protected:
X86Abort(const char * name, const char * mnem,
-const uint8_t vector, uint64_t _errorCode = -1) :
-X86FaultBase(name, mnem, vector, _errorCode)
+const uint8_t vector, uint64_t _errorCode = (uint64_t)-1)
+: X86FaultBase(name, mnem, vector, _errorCode)
{}
#if FULL_SYSTEM
@@ -154,8 +154,8 @@
{
protected:
X86Interrupt(const char * name, const char * mnem,
-const uint8_t _vector, uint64_t _errorCode = -1) :
-X86FaultBase(name, mnem, _vector, _errorCode)
+const uint8_t _vector, uint64_t _errorCode = (uint64_t)-1)
+: X86FaultBase(name, mnem, _vector, _errorCode)
{}
};
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] changeset in m5: build: fix compiler warnings in g++ 3.4
Seems like it would be worth setting up a slew of g++ revs on zizzer and running regressions under all of them, maybe on a rotating basis... Steve ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] changeset in m5: build: fix compiler warnings in g++ 3.4
Seems like it would be worth setting up a slew of g++ revs on zizzer and running regressions under all of them, maybe on a rotating basis... Yeah, I agree. Multiple revs of swig and maybe scons would be good too. I think we should set up a separate compile everything regression actually. It doesn't take that long to compile the tree, and with the pool being available, we could just compile a bunch of combinations. Nate ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
