Re: [m5-dev] please mark reviews for committed patches as such
When you go to the page for a particular entry you've submitted there's a dropdown menu that lets you close the entry and mark it either as submitted or discarded. I can't be more specific since I don't have any outstanding reviews to look at myself. Steve On Thu, Oct 21, 2010 at 12:55 PM, Gabriel Michael Black wrote: > Yeah, I'd noticed that too but I wasn't sure what to do about it. I'll take > care of mine tonight. > > Gabe > > Quoting Steve Reinhardt : > >> Hi folks, >> >> Just a reminder that once you've committed a patch to the repo, you >> should go back to reviewboard and mark the corresponding review >> submission as "submitted". The review request list is getting pretty >> long, and I know there are some patches in there that have been >> committed and so don't really need reviewing anymore. >> >> Thanks, >> >> Steve >> ___ >> m5-dev mailing list >> m5-dev@m5sim.org >> http://m5sim.org/mailman/listinfo/m5-dev >> > > > > ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
Re: [m5-dev] please mark reviews for committed patches as such
Yeah, I'd noticed that too but I wasn't sure what to do about it. I'll take care of mine tonight. Gabe Quoting Steve Reinhardt : Hi folks, Just a reminder that once you've committed a patch to the repo, you should go back to reviewboard and mark the corresponding review submission as "submitted". The review request list is getting pretty long, and I know there are some patches in there that have been committed and so don't really need reviewing anymore. Thanks, Steve ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
[m5-dev] please mark reviews for committed patches as such
Hi folks, Just a reminder that once you've committed a patch to the repo, you should go back to reviewboard and mark the corresponding review submission as "submitted". The review request list is getting pretty long, and I know there are some patches in there that have been committed and so don't really need reviewing anymore. Thanks, Steve ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev
