[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-10-12 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby: FAILED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby: FAILED! * build/ALPHA/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby: FAILED! *

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
> On Oct. 10, 2016, 9:58 p.m., Tony Gutierrez wrote: > > Ship It! I've taken another stab at fixing this in a less hackish way. I took a first stab at making the shared config modules Python packages (as they should have been all along). Have a look and let me know what you think. - Andreas

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3624/#review8821 --- ext/libelf/elf_common.h (line 175)

Re: [gem5-dev] Review Request 3659: stats: Add more information to uninitialized error

2016-10-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3659/#review8820 --- Ship it! Ship It! - Andreas Hansson On Oct. 11, 2016, 2:45 p.m.,

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/ --- (Updated Oct. 12, 2016, 8:55 a.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
> On Oct. 12, 2016, 2:21 p.m., Jason Lowe-Power wrote: > > I like this approach! A couple of comments,though. > > > > 1. I think you need to add an __init__.py file to each directory (ruby, > > topologies, network) for this to work. Did you forget to hg add them? > > 2. Since we don't have

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/ --- (Updated Oct. 12, 2016, 2:30 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3639: Fix for ARM's Streamline conversion script.

2016-10-12 Thread Shawn Rosti
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3639/#review8827 --- - Shawn Rosti On Oct. 12, 2016, 2:55 p.m., Shawn Rosti wrote: > >

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8824 --- I like this approach! A couple of comments,though. 1. I think you need

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8826 --- Ship it! Thanks again for doing this! - Jason Lowe-Power On Oct. 12,

Re: [gem5-dev] Review Request 3639: Fix for ARM's Streamline conversion script.

2016-10-12 Thread Shawn Rosti
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3639/ --- (Updated Oct. 12, 2016, 2:55 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3647: ruby: Fix regressions and make Ruby configs Python packages

2016-10-12 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3647/#review8823 --- Ship it! Ship It! - Tony Gutierrez On Oct. 12, 2016, 1:55 a.m.,

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-10-12 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3591/#review8828 --- Ship it! Ship It! - Jason Lowe-Power On Aug. 30, 2016, 3:54 p.m.,

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

2016-10-12 Thread Michael LeBeane
> On Sept. 9, 2016, 2:53 p.m., Gabor Dozsa wrote: > > src/dev/net/dist_iface.cc, line 71 > > > > > > This change effectively disables the use of the start_tick parameter. > > It is because 'nextAt' is overwritten in

Re: [gem5-dev] Review Request 3595: dev: Add m5 op to toggle synchronization for dist-gem5.

2016-10-12 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3595/ --- (Updated Oct. 12, 2016, 3:51 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3591: ruby: Allow multiple outstanding DMA requests

2016-10-12 Thread Michael LeBeane
> On Sept. 1, 2016, 3:33 p.m., Jason Lowe-Power wrote: > > What testing did you perform to make sure all of the protocols were > > modified correctly? > > > > Most of these changes seem reasonable to me, but I know from experience > > that even when the SLICC changes seem like they are right,

Re: [gem5-dev] Review Request 3630: riscv: [Patch 5/5] Added missing support for timing CPU models

2016-10-12 Thread Alec Roelke
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3630/ --- (Updated Oct. 12, 2016, 4:47 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3493: dev: Add 'simLength' parameter in EthPacketData

2016-10-12 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3493/ --- (Updated Oct. 12, 2016, 3:50 p.m.) Review request for Default. Summary (updated)

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-12 Thread Alec Roelke
> On Oct. 12, 2016, 8:31 a.m., Andreas Hansson wrote: > > src/arch/riscv/process.cc, line 189 > > > > > > Not that it really matters, but feel free to use "auto" Actually I think I'll just use "int" as most people do. I'm

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-12 Thread Alec Roelke
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3624/ --- (Updated Oct. 12, 2016, 4:46 p.m.) Review request for Default. Repository: gem5