Re: [gem5-dev] gem5 19.0.0 : New git branching proposal

Thanks Bobby for pushing this forward, having releases would be a good thing for gem5. I would recommend against having both master and develop branch though, because in the large majority of projects out there, master == the latest version, so I'm always confused when I have to switch to

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Disambuiguate NumFloatV7ArchRegs usage

Hello Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/23107 to review the following change. Change subject: arch-arm: Disambuiguate NumFloatV7ArchRegs usage

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Reorder arch/arm/registers.hh constants

Hello Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/23104 to review the following change. Change subject: arch-arm: Reorder arch/arm/registers.hh constants

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Replace NumFloatV8ArchRegs with NumVecV8ArchRegs

Hello Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/23103 to review the following change. Change subject: arch-arm: Replace NumFloatV8ArchRegs with NumVecV8ArchRegs

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Unify VLdmStm behaviour when reg out of index

Hello Ciro Santilli, Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/23106 to review the following change. Change subject: arch-arm: Unify VLdmStm behaviour when reg out of index

[gem5-dev] Change in gem5/gem5[master]: arch-arm: Fix NumVecV7ArchRegs value (64->16)

Hello Nikos Nikoleris, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/23105 to review the following change. Change subject: arch-arm: Fix NumVecV7ArchRegs value (64->16)

[gem5-dev] Change in gem5/gem5[master]: base: Fix DPRINTF_UNCONDITIONAL on gem5.fast

Hello Ciro Santilli, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/23108 to review the following change. Change subject: base: Fix DPRINTF_UNCONDITIONAL on gem5.fast

Re: [gem5-dev] gem5 19.0.0 : New git branching proposal

Thanks for the input Ciro! My pushback here is that most people who use gem5 will be making modifications to it (at least for the foreseeable future). I don't think we want to common use case to be 1) Download a tarball, 2) make local modifications to the source. I think we want people to 1)

[gem5-dev] ARM KVM HLT instruction and semihosting

Hi ARM folks. I'm trying to rationalize the various ways pseudo instructions are done in KVM, fast models and native gem5 CPUs, and obviate the magical address range they sometimes use. KVM has turned out to be a very tricky case since there isn't really a great way to wrestle control out of the

[gem5-dev] Change in gem5/gem5[master]: arm: Make sure not to shift off of the end of a uint32_t in KVM.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23129 ) Change subject: arm: Make sure not to shift off of the end of a uint32_t in KVM. .. arm: Make sure not to

Re: [gem5-dev] gem5 19.0.0 : New git branching proposal

I agree with Ciro that the de facto standard used by most projects is that mainline development should happen in master and releases should be new branches created off of master. You could also create a branch “stable” or “latest” that gets updated to the latest release. The default download

[gem5-dev] Change in gem5/gem5[master]: sim-se: remove serialize methods from memstate

Brandon Potter has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23144 ) Change subject: sim-se: remove serialize methods from memstate .. sim-se: remove serialize methods from

[gem5-dev] Change in gem5/gem5[master]: sim-se, tests: Add Region class and basic tests

Brandon Potter has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23143 ) Change subject: sim-se,tests: Add Region class and basic tests .. sim-se,tests: Add Region class and basic

[gem5-dev] Change in gem5/gem5[master]: sim-se: replace memstate api with regions

Brandon Potter has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23146 ) Change subject: sim-se: replace memstate api with regions .. sim-se: replace memstate api with regions This

[gem5-dev] Change in gem5/gem5[master]: base: add features to MemoryImage::Segment

Brandon Potter has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23145 ) Change subject: base: add features to MemoryImage::Segment .. base: add features to MemoryImage::Segment

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Remove a std::move clang says is unnecessary.

Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23124 ) Change subject: mem-cache: Remove a std::move clang says is unnecessary. .. mem-cache: Remove a std::move clang says is

[gem5-dev] Change in gem5/gem5[master]: mem-cache: Avoid hiding a virtual method in the dictionary compressor.

Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23127 ) Change subject: mem-cache: Avoid hiding a virtual method in the dictionary compressor. .. mem-cache: Avoid hiding a

[gem5-dev] Change in gem5/gem5[master]: arm: Make sure not to shift off of the end of a uint32_t in KVM.

Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23129 ) Change subject: arm: Make sure not to shift off of the end of a uint32_t in KVM. .. arm: Make sure not to shift off of

[gem5-dev] Change in gem5/gem5[master]: arch, sim: Promote the m5ops_base param to the System base class.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23180 ) Change subject: arch,sim: Promote the m5ops_base param to the System base class. .. arch,sim: Promote the

[gem5-dev] Change in gem5/gem5[master]: arch, sim: Stop decoding the pseudo inst subfunc value.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23179 ) Change subject: arch,sim: Stop decoding the pseudo inst subfunc value. .. arch,sim: Stop decoding the pseudo inst

[gem5-dev] Change in gem5/gem5[master]: sim: Convert most of the common syscalls to use the guest ABI.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23193 ) Change subject: sim: Convert most of the common syscalls to use the guest ABI. .. sim: Convert most of the

[gem5-dev] Change in gem5/gem5[master]: arch: Stop using setSyscallArg to set argc and argv.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23173 ) Change subject: arch: Stop using setSyscallArg to set argc and argv. .. arch: Stop using setSyscallArg to set

[gem5-dev] Change in gem5/gem5[master]: arch, cpu, mem: Replace the mmmapped IPR mechanism with local accesses.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23188 ) Change subject: arch,cpu,mem: Replace the mmmapped IPR mechanism with local accesses. .. arch,cpu,mem: Replace

[gem5-dev] Change in gem5/gem5[master]: sim, arch: Collapse the ISA specific versions of m5Syscall.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23177 ) Change subject: sim,arch: Collapse the ISA specific versions of m5Syscall. .. sim,arch: Collapse the ISA specific

[gem5-dev] Change in gem5/gem5[master]: sim: Implement a varargs like mechanism for GuestABI system.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23195 ) Change subject: sim: Implement a varargs like mechanism for GuestABI system. .. sim: Implement a varargs like

[gem5-dev] Change in gem5/gem5[master]: sim: Add a wrapper/subclass for SyscallDesc which uses GuestABI.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23172 ) Change subject: sim: Add a wrapper/subclass for SyscallDesc which uses GuestABI. .. sim: Add a

[gem5-dev] Change in gem5/gem5[master]: x86: Use the m5 op range in the system.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23182 ) Change subject: x86: Use the m5 op range in the system. .. x86: Use the m5 op range in the system. Don't hard

[gem5-dev] Change in gem5/gem5[master]: arch: Switch SyscallDescABI in for SyscallDesc.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23191 ) Change subject: arch: Switch SyscallDescABI in for SyscallDesc. .. arch: Switch SyscallDescABI in for

[gem5-dev] Change in gem5/gem5[master]: arch: Get rid of the now unused setSyscallArg.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23174 ) Change subject: arch: Get rid of the now unused setSyscallArg. .. arch: Get rid of the now unused setSyscallArg.

[gem5-dev] Change in gem5/gem5[master]: sim: Use _m5opRange in System::allocPhysPages.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23181 ) Change subject: sim: Use _m5opRange in System::allocPhysPages. .. sim: Use _m5opRange in System::allocPhysPages.

[gem5-dev] Change in gem5/gem5[master]: sim: Add a mechanism to translate ABIs to call host funcs from a TC.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23171 ) Change subject: sim: Add a mechanism to translate ABIs to call host funcs from a TC. .. sim: Add a mechanism

[gem5-dev] Change in gem5/gem5[master]: arch: Simplify the SyscallDesc tables.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23189 ) Change subject: arch: Simplify the SyscallDesc tables. .. arch: Simplify the SyscallDesc tables. By using braced

[gem5-dev] Change in gem5/gem5[master]: sim: Change the syscall executor to a std::function.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23164 ) Change subject: sim: Change the syscall executor to a std::function. .. sim: Change the syscall executor to a

[gem5-dev] Change in gem5/gem5[master]: arch, sim: Replace setuidFunc with ignoreFunc.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23194 ) Change subject: arch,sim: Replace setuidFunc with ignoreFunc. .. arch,sim: Replace setuidFunc with ignoreFunc.

[gem5-dev] Change in gem5/gem5[master]: mem: Eliminate the now unused GENERIC_IPR request flag.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23187 ) Change subject: mem: Eliminate the now unused GENERIC_IPR request flag. .. mem: Eliminate the now unused

[gem5-dev] Change in gem5/gem5[master]: sim: Small style fixes in sim/syscall_return.hh.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23165 ) Change subject: sim: Small style fixes in sim/syscall_return.hh. .. sim: Small style fixes in

[gem5-dev] Change in gem5/gem5[master]: x86: Stop manually clearing RFLAGS.RF after a system call.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23175 ) Change subject: x86: Stop manually clearing RFLAGS.RF after a system call. .. x86: Stop manually clearing

[gem5-dev] Change in gem5/gem5[master]: arch, sim: Use the guest ABI mechanism with pseudo instructions.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23178 ) Change subject: arch,sim: Use the guest ABI mechanism with pseudo instructions. .. arch,sim: Use the guest ABI

[gem5-dev] Change in gem5/gem5[master]: sim: Reintroduce the ignoreWarnOnceFunc syscall handler.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23168 ) Change subject: sim: Reintroduce the ignoreWarnOnceFunc syscall handler. .. sim: Reintroduce the

[gem5-dev] Change in gem5/gem5[master]: arch: Use ignoreWarnOnceFunc instead of the WarnOnce flag.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23169 ) Change subject: arch: Use ignoreWarnOnceFunc instead of the WarnOnce flag. .. arch: Use ignoreWarnOnceFunc

[gem5-dev] Change in gem5/gem5[master]: sim: Add a unit test for the GuestABI mechanism.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23197 ) Change subject: sim: Add a unit test for the GuestABI mechanism. .. sim: Add a unit test for the GuestABI

[gem5-dev] Change in gem5/gem5[master]: sim: Get rid of the now unused SyscallDesc flags and methods.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23170 ) Change subject: sim: Get rid of the now unused SyscallDesc flags and methods. .. sim: Get rid of the now

[gem5-dev] Change in gem5/gem5[master]: sparc: Fix the predecoder's moreBytes method.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23163 ) Change subject: sparc: Fix the predecoder's moreBytes method. .. sparc: Fix the predecoder's moreBytes method.

[gem5-dev] Change in gem5/gem5[master]: sim: Use the Guest ABI mechanism in writeFunc.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23192 ) Change subject: sim: Use the Guest ABI mechanism in writeFunc. .. sim: Use the Guest ABI mechanism in writeFunc.

[gem5-dev] Change in gem5/gem5[master]: x86: Handle m5 op accesses directly in the mmapped IPR handlers.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23184 ) Change subject: x86: Handle m5 op accesses directly in the mmapped IPR handlers. .. x86: Handle m5 op accesses

[gem5-dev] Change in gem5/gem5[master]: sim: Remove special KVM handling of the return from clone.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23199 ) Change subject: sim: Remove special KVM handling of the return from clone. .. sim: Remove special KVM handling of

[gem5-dev] Change in gem5/gem5[master]: arch, sim: Convert clone to GuestABI and define a cloneBackwardsFunc.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23198 ) Change subject: arch,sim: Convert clone to GuestABI and define a cloneBackwardsFunc. .. arch,sim: Convert

[gem5-dev] Change in gem5/gem5[master]: sim: Add a transitional syscall ABI which defers to Process.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23190 ) Change subject: sim: Add a transitional syscall ABI which defers to Process. .. sim: Add a transitional syscall

[gem5-dev] Change in gem5/gem5[master]: arch: Get rid of the generic mmapped IPR mechanism.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23186 ) Change subject: arch: Get rid of the generic mmapped IPR mechanism. .. arch: Get rid of the generic mmapped IPR

[gem5-dev] Change in gem5/gem5[master]: sim: Make the syscalls use the SyscallReturn suppression mechanism.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23167 ) Change subject: sim: Make the syscalls use the SyscallReturn suppression mechanism. .. sim: Make the syscalls

[gem5-dev] Change in gem5/gem5[master]: sim: Add a suppression mechanism to the SyscallReturn class.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23166 ) Change subject: sim: Add a suppression mechanism to the SyscallReturn class. .. sim: Add a suppression mechanism

[gem5-dev] Change in gem5/gem5[master]: arch, cpu, sim: Push syscall number determination up to processes.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23176 ) Change subject: arch,cpu,sim: Push syscall number determination up to processes. .. arch,cpu,sim: Push syscall

[gem5-dev] Change in gem5/gem5[master]: sim: Add a function for decoding the field(s) of an m5op address.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23183 ) Change subject: sim: Add a function for decoding the field(s) of an m5op address. .. sim: Add a function for

[gem5-dev] Change in gem5/gem5[master]: arm: Call pseudoInst directly from the mmapped IPR handlers.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23185 ) Change subject: arm: Call pseudoInst directly from the mmapped IPR handlers. .. arm: Call pseudoInst directly

[gem5-dev] Change in gem5/gem5[master]: sim: Use variadic GuestABI arguments in a few additional syscalls.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23196 ) Change subject: sim: Use variadic GuestABI arguments in a few additional syscalls. .. sim: Use variadic

Re: [gem5-dev] gem5 19.0.0 : New git branching proposal

The idea of feature branches makes me very nervous. It sounds like a dark corner for a large body of code to grow in, and then once it pops back into the light there may be very ingrained and difficult to fix problems which either have to be ignored or fixed. A long standing branch may also be

[gem5-dev] Cron /z/m5/regression/do-regression --scratch all

* build/ALPHA/tests/opt/long/fs/10.linux-boot/alpha/linux/tsunami-o3: FAILED! * build/ALPHA/tests/opt/long/fs/10.linux-boot/alpha/linux/tsunami-switcheroo-full: FAILED! * build/ALPHA/tests/opt/long/fs/10.linux-boot/alpha/linux/tsunami-o3-dual: FAILED! *

[gem5-dev] Cron /z/m5/regression/do-regression quick

* build/NULL/tests/opt/quick/se/51.memcheck/null/none/memcheck: FAILED! * build/SPARC/tests/opt/quick/se/70.twolf/sparc/linux/simple-atomic: FAILED! * build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-atomic: FAILED! *

[gem5-dev] Change in gem5/gem5[master]: base: Fix DPRINTF_UNCONDITIONAL on gem5.fast

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23108 ) Change subject: base: Fix DPRINTF_UNCONDITIONAL on gem5.fast .. base: Fix DPRINTF_UNCONDITIONAL on gem5.fast

[gem5-dev] Change in gem5/gem5[master]: configs: Add --redirects for syscall emulation

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23065 ) Change subject: configs: Add --redirects for syscall emulation .. configs: Add --redirects for syscall emulation

[gem5-dev] Change in gem5/gem5[master]: base, python: Allow dirname selection for the interpreter

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23066 ) Change subject: base, python: Allow dirname selection for the interpreter .. base, python: Allow dirname selection

[gem5-dev] Change in gem5/gem5[master]: configs: Fix baremetal platform

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23083 ) Change subject: configs: Fix baremetal platform .. configs: Fix baremetal platform With

[gem5-dev] Change in gem5/gem5[master]: sim-se: Check Path redirection when mmapping

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23063 ) Change subject: sim-se: Check Path redirection when mmapping .. sim-se: Check Path redirection when mmapping Every

[gem5-dev] Change in gem5/gem5[master]: configs: Add root redirect path in SE mode only when set

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/23064 ) Change subject: configs: Add root redirect path in SE mode only when set .. configs: Add root redirect path in SE

[gem5-dev] Change in gem5/gem5[master]: systemc: Fix up some lingering Accellera specific code in TLM v1.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23128 ) Change subject: systemc: Fix up some lingering Accellera specific code in TLM v1. .. systemc: Fix up some

[gem5-dev] Change in gem5/gem5[master]: fastmodel: Suppress a spurious warning on clang for amba_pv.h.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23123 ) Change subject: fastmodel: Suppress a spurious warning on clang for amba_pv.h. .. fastmodel: Suppress a

[gem5-dev] Change in gem5/gem5[master]: systemc: Add a bunch of missing overrides to the systemc headers.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23125 ) Change subject: systemc: Add a bunch of missing overrides to the systemc headers. .. systemc: Add a bunch of

[gem5-dev] Change in gem5/gem5[master]: systemc: Suppress a spurious clang warning in the systemc headers.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23126 ) Change subject: systemc: Suppress a spurious clang warning in the systemc headers. .. systemc: Suppress a

[gem5-dev] Change in gem5/gem5[master]: mem: Avoid hiding a virtual method in the dictionary compressor.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23127 ) Change subject: mem: Avoid hiding a virtual method in the dictionary compressor. .. mem: Avoid hiding a

[gem5-dev] Change in gem5/gem5[master]: mem: Remove a std::move clang says is unnecessary.

Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/23124 ) Change subject: mem: Remove a std::move clang says is unnecessary. .. mem: Remove a std::move clang says is