Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/30242 )
Change subject: ext: Remove dead code from configuration.py
..
ext: Remove dead code from configuration.py
This has been tested with vulture:
https://pypi.org/project/vulture
JIRA: https://gem5.atlassian.net/projects/GEM5/issues/GEM5-533
Change-Id: Ibaf812ace94c2ae0e2115552a87fb506a427bb89
Signed-off-by: Giacomo Travaglini
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30242
Tested-by: kokoro
Reviewed-by: Jason Lowe-Power
Maintainer: Jason Lowe-Power
---
M ext/testlib/configuration.py
1 file changed, 0 insertions(+), 7 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/ext/testlib/configuration.py b/ext/testlib/configuration.py
index b7c4697..cebb98f 100644
--- a/ext/testlib/configuration.py
+++ b/ext/testlib/configuration.py
@@ -84,7 +84,6 @@
import re
from six import add_metaclass
-from six.moves import configparser as ConfigParser
from pickle import HIGHEST_PROTOCOL as highest_pickle_protocol
from testlib.helper import absdirpath, AttrDict, FrozenAttrDict
@@ -132,11 +131,6 @@
self._run_post_processors()
self._initialized = True
-def _init_with_dicts(self, config, defaults):
-self._config = config
-self._defaults = defaults
-self._initialized = True
-
def _add_post_processor(self, attr, post_processor):
'''
:param attr: Attribute to pass to and recieve from the
@@ -220,7 +214,6 @@
os.pardir,
os.pardir))
defaults.result_path = os.path.join(os.getcwd(), '.testing-results')
-defaults.list_only_failed = False
defaults.resource_url = 'http://dist.gem5.org/dist/develop'
def define_constants(constants):
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/30242
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibaf812ace94c2ae0e2115552a87fb506a427bb89
Gerrit-Change-Number: 30242
Gerrit-PatchSet: 5
Gerrit-Owner: Giacomo Travaglini
Gerrit-Reviewer: Bobby R. Bruce
Gerrit-Reviewer: Giacomo Travaglini
Gerrit-Reviewer: Hoa Nguyen
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s