[gem5-dev] Change in gem5/gem5[develop]: util, x86: Use M5OP_FOREACH to define the m5op entry points for x86.

2020-04-01 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27208 )


Change subject: util,x86: Use M5OP_FOREACH to define the m5op entry points  
for x86.

..

util,x86: Use M5OP_FOREACH to define the m5op entry points for x86.

Change-Id: Idbfa3341a5e0d2cf57ce7dbe8cf45834b3aa067a
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/27208
Tested-by: kokoro 
Reviewed-by: Jason Lowe-Power 
Reviewed-by: Daniel Carvalho 
Maintainer: Bobby R. Bruce 
---
M util/m5/m5op_x86.S
1 file changed, 3 insertions(+), 24 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved
  Daniel Carvalho: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/util/m5/m5op_x86.S b/util/m5/m5op_x86.S
index 453cdc9..cd83a94 100644
--- a/util/m5/m5op_x86.S
+++ b/util/m5/m5op_x86.S
@@ -79,27 +79,6 @@

 #endif

-TWO_BYTE_OP(m5_arm, M5OP_ARM)
-TWO_BYTE_OP(m5_quiesce, M5OP_QUIESCE)
-TWO_BYTE_OP(m5_quiesce_ns, M5OP_QUIESCE_NS)
-TWO_BYTE_OP(m5_quiesce_cycle, M5OP_QUIESCE_CYCLE)
-TWO_BYTE_OP(m5_quiesce_time, M5OP_QUIESCE_TIME)
-TWO_BYTE_OP(m5_rpns, M5OP_RPNS)
-TWO_BYTE_OP(m5_wake_cpu, M5OP_WAKE_CPU)
-TWO_BYTE_OP(m5_exit, M5OP_EXIT)
-TWO_BYTE_OP(m5_fail, M5OP_FAIL)
-TWO_BYTE_OP(m5_init_param, M5OP_INIT_PARAM)
-TWO_BYTE_OP(m5_load_symbol, M5OP_LOAD_SYMBOL)
-TWO_BYTE_OP(m5_reset_stats, M5OP_RESET_STATS)
-TWO_BYTE_OP(m5_dump_stats, M5OP_DUMP_STATS)
-TWO_BYTE_OP(m5_dump_reset_stats, M5OP_DUMP_RESET_STATS)
-TWO_BYTE_OP(m5_checkpoint, M5OP_CHECKPOINT)
-TWO_BYTE_OP(m5_read_file, M5OP_READ_FILE)
-TWO_BYTE_OP(m5_write_file, M5OP_WRITE_FILE)
-TWO_BYTE_OP(m5_debug_break, M5OP_DEBUG_BREAK)
-TWO_BYTE_OP(m5_switch_cpu, M5OP_SWITCH_CPU)
-TWO_BYTE_OP(m5_add_symbol, M5OP_ADD_SYMBOL)
-TWO_BYTE_OP(m5_panic, M5OP_PANIC)
-TWO_BYTE_OP(m5_work_begin, M5OP_WORK_BEGIN)
-TWO_BYTE_OP(m5_work_end, M5OP_WORK_END)
-TWO_BYTE_OP(m5_dist_toggle_sync, M5OP_DIST_TOGGLE_SYNC)
+#define M5OP(name, number) TWO_BYTE_OP(name, number)
+M5OP_FOREACH
+#undef M5OP

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27208
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Idbfa3341a5e0d2cf57ce7dbe8cf45834b3aa067a
Gerrit-Change-Number: 27208
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Earl Ou 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Yu-hsin Wang 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[develop]: util, x86: Use M5OP_FOREACH to define the m5op entry points for x86.

2020-03-27 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/27208 )



Change subject: util,x86: Use M5OP_FOREACH to define the m5op entry points  
for x86.

..

util,x86: Use M5OP_FOREACH to define the m5op entry points for x86.

Change-Id: Idbfa3341a5e0d2cf57ce7dbe8cf45834b3aa067a
---
M util/m5/m5op_x86.S
1 file changed, 3 insertions(+), 24 deletions(-)



diff --git a/util/m5/m5op_x86.S b/util/m5/m5op_x86.S
index 453cdc9..cd83a94 100644
--- a/util/m5/m5op_x86.S
+++ b/util/m5/m5op_x86.S
@@ -79,27 +79,6 @@

 #endif

-TWO_BYTE_OP(m5_arm, M5OP_ARM)
-TWO_BYTE_OP(m5_quiesce, M5OP_QUIESCE)
-TWO_BYTE_OP(m5_quiesce_ns, M5OP_QUIESCE_NS)
-TWO_BYTE_OP(m5_quiesce_cycle, M5OP_QUIESCE_CYCLE)
-TWO_BYTE_OP(m5_quiesce_time, M5OP_QUIESCE_TIME)
-TWO_BYTE_OP(m5_rpns, M5OP_RPNS)
-TWO_BYTE_OP(m5_wake_cpu, M5OP_WAKE_CPU)
-TWO_BYTE_OP(m5_exit, M5OP_EXIT)
-TWO_BYTE_OP(m5_fail, M5OP_FAIL)
-TWO_BYTE_OP(m5_init_param, M5OP_INIT_PARAM)
-TWO_BYTE_OP(m5_load_symbol, M5OP_LOAD_SYMBOL)
-TWO_BYTE_OP(m5_reset_stats, M5OP_RESET_STATS)
-TWO_BYTE_OP(m5_dump_stats, M5OP_DUMP_STATS)
-TWO_BYTE_OP(m5_dump_reset_stats, M5OP_DUMP_RESET_STATS)
-TWO_BYTE_OP(m5_checkpoint, M5OP_CHECKPOINT)
-TWO_BYTE_OP(m5_read_file, M5OP_READ_FILE)
-TWO_BYTE_OP(m5_write_file, M5OP_WRITE_FILE)
-TWO_BYTE_OP(m5_debug_break, M5OP_DEBUG_BREAK)
-TWO_BYTE_OP(m5_switch_cpu, M5OP_SWITCH_CPU)
-TWO_BYTE_OP(m5_add_symbol, M5OP_ADD_SYMBOL)
-TWO_BYTE_OP(m5_panic, M5OP_PANIC)
-TWO_BYTE_OP(m5_work_begin, M5OP_WORK_BEGIN)
-TWO_BYTE_OP(m5_work_end, M5OP_WORK_END)
-TWO_BYTE_OP(m5_dist_toggle_sync, M5OP_DIST_TOGGLE_SYNC)
+#define M5OP(name, number) TWO_BYTE_OP(name, number)
+M5OP_FOREACH
+#undef M5OP

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/27208
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Idbfa3341a5e0d2cf57ce7dbe8cf45834b3aa067a
Gerrit-Change-Number: 27208
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev