[gem5-dev] Change in gem5/gem5[master]: dev: arm: SetScaling commands don't send parameter bytes.

2018-04-10 Thread Gabe Black (Gerrit)
Gabe Black has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/9701 )


Change subject: dev: arm: SetScaling commands don't send parameter bytes.
..

dev: arm: SetScaling commands don't send parameter bytes.

These are single byte commands which change the mode of the mouse. They  
don't

take any additional parameters like the SetRate or SetResolution.

Change-Id: I29194916cfed5d3f4893947ef6d6cc636aee2419
Reviewed-on: https://gem5-review.googlesource.com/9701
Reviewed-by: Andreas Sandberg 
Maintainer: Andreas Sandberg 
---
M src/dev/arm/kmi.cc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Andreas Sandberg: Looks good to me, approved; Looks good to me, approved



diff --git a/src/dev/arm/kmi.cc b/src/dev/arm/kmi.cc
index 8db9254..8b373b8 100644
--- a/src/dev/arm/kmi.cc
+++ b/src/dev/arm/kmi.cc
@@ -188,8 +188,6 @@
   case SetResolution:
   case SetRate:
   case SetStatusLed:
-  case SetScaling1_1:
-  case SetScaling1_2:
 rxQueue.push_back(Ack);
 ackNext = 1;
 break;
@@ -211,6 +209,8 @@
   case Disable:
   case Enable:
   case SetDefaults:
+  case SetScaling1_1:
+  case SetScaling1_2:
 rxQueue.push_back(Ack);
 break;
   case StatusRequest:

--
To view, visit https://gem5-review.googlesource.com/9701
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I29194916cfed5d3f4893947ef6d6cc636aee2419
Gerrit-Change-Number: 9701
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Gabe Black 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: dev: arm: SetScaling commands don't send parameter bytes.

2018-04-06 Thread Gabe Black (Gerrit)
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/9701



Change subject: dev: arm: SetScaling commands don't send parameter bytes.
..

dev: arm: SetScaling commands don't send parameter bytes.

These are single byte commands which change the mode of the mouse. They  
don't

take any additional parameters like the SetRate or SetResolution.

Change-Id: I29194916cfed5d3f4893947ef6d6cc636aee2419
---
M src/dev/arm/kmi.cc
1 file changed, 2 insertions(+), 2 deletions(-)



diff --git a/src/dev/arm/kmi.cc b/src/dev/arm/kmi.cc
index 8db9254..8b373b8 100644
--- a/src/dev/arm/kmi.cc
+++ b/src/dev/arm/kmi.cc
@@ -188,8 +188,6 @@
   case SetResolution:
   case SetRate:
   case SetStatusLed:
-  case SetScaling1_1:
-  case SetScaling1_2:
 rxQueue.push_back(Ack);
 ackNext = 1;
 break;
@@ -211,6 +209,8 @@
   case Disable:
   case Enable:
   case SetDefaults:
+  case SetScaling1_1:
+  case SetScaling1_2:
 rxQueue.push_back(Ack);
 break;
   case StatusRequest:

--
To view, visit https://gem5-review.googlesource.com/9701
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I29194916cfed5d3f4893947ef6d6cc636aee2419
Gerrit-Change-Number: 9701
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev