[gem5-dev] Change in public/gem5[master]: base: Update #includes for bitunion.hh.
Gabe Black has submitted this change and it was merged. ( https://gem5-review.googlesource.com/7781 ) Change subject: base: Update #includes for bitunion.hh. .. base: Update #includes for bitunion.hh. isn't actually used anywhere in bitunion.hh. The templated hash struct type is defined in and should be included explicitly. Change-Id: I8691ccb2f9e28a01610ae8bb4d9591b07cb7320b Reviewed-on: https://gem5-review.googlesource.com/7781 Reviewed-by: Matthias Jung Maintainer: Gabe Black --- M src/base/bitunion.hh 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Matthias Jung: Looks good to me, approved Gabe Black: Looks good to me, approved diff --git a/src/base/bitunion.hh b/src/base/bitunion.hh index 38d10da..569d650 100644 --- a/src/base/bitunion.hh +++ b/src/base/bitunion.hh @@ -31,7 +31,7 @@ #ifndef __BASE_BITUNION_HH__ #define __BASE_BITUNION_HH__ -#include +#include #include #include "base/bitfield.hh" @@ -404,9 +404,6 @@ namespace std { template -struct hash; - -template struct hash > : public hash > { size_t -- To view, visit https://gem5-review.googlesource.com/7781 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8691ccb2f9e28a01610ae8bb4d9591b07cb7320b Gerrit-Change-Number: 7781 Gerrit-PatchSet: 3 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Matthias Jung ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: base: Update #includes for bitunion.hh.
Hello Matthias Jung, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/7781 to look at the new patch set (#2). Change subject: base: Update #includes for bitunion.hh. .. base: Update #includes for bitunion.hh. isn't actually used anywhere in bitunion.hh. The templated hash struct type is defined in and should be included explicitly. Change-Id: I8691ccb2f9e28a01610ae8bb4d9591b07cb7320b --- M src/base/bitunion.hh 1 file changed, 1 insertion(+), 4 deletions(-) -- To view, visit https://gem5-review.googlesource.com/7781 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8691ccb2f9e28a01610ae8bb4d9591b07cb7320b Gerrit-Change-Number: 7781 Gerrit-PatchSet: 2 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Matthias Jung ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: base: Update #includes for bitunion.hh.
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/7781 Change subject: base: Update #includes for bitunion.hh. .. base: Update #includes for bitunion.hh. isn't actually used anywhere in bitunion.hh. The templated hash struct type is defined in and should be included explicitly. Change-Id: I8691ccb2f9e28a01610ae8bb4d9591b07cb7320b --- M src/base/bitunion.hh 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/base/bitunion.hh b/src/base/bitunion.hh index 38d10da..fdfbcb0 100644 --- a/src/base/bitunion.hh +++ b/src/base/bitunion.hh @@ -31,7 +31,7 @@ #ifndef __BASE_BITUNION_HH__ #define __BASE_BITUNION_HH__ -#include +#include #include #include "base/bitfield.hh" -- To view, visit https://gem5-review.googlesource.com/7781 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8691ccb2f9e28a01610ae8bb4d9591b07cb7320b Gerrit-Change-Number: 7781 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev