[gem5-dev] Change in public/gem5[master]: mem-cache: Allow prefetchers to override setCache.

2018-03-06 Thread Gabe Black (Gerrit) 
Gabe Black has submitted this change and it was merged. (  
https://gem5-review.googlesource.com/8701 )


Change subject: mem-cache: Allow prefetchers to override setCache.
..

mem-cache: Allow prefetchers to override setCache.

This lets them hook setCache, perhaps to set up additional state based
on the set cache.

Change-Id: Ic3b34fa43d052c71e8ef733a57fe47c70899cd27
Reviewed-on: https://gem5-review.googlesource.com/8701
Reviewed-by: Jason Lowe-Power 
Maintainer: Gabe Black 
---
M src/mem/cache/prefetch/base.hh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved
  Gabe Black: Looks good to me, approved



diff --git a/src/mem/cache/prefetch/base.hh b/src/mem/cache/prefetch/base.hh
index 683c59f..3b23106 100644
--- a/src/mem/cache/prefetch/base.hh
+++ b/src/mem/cache/prefetch/base.hh
@@ -125,7 +125,7 @@

 virtual ~BasePrefetcher() {}

-void setCache(BaseCache *_cache);
+virtual void setCache(BaseCache *_cache);

 /**
  * Notify prefetcher of cache access (may be any access or just

--
To view, visit https://gem5-review.googlesource.com/8701
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic3b34fa43d052c71e8ef733a57fe47c70899cd27
Gerrit-Change-Number: 8701
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black 
Gerrit-Assignee: Nikos Nikoleris 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Xiaoyu Ma 
Gerit-CC: Andreas Sandberg 
Gerit-CC: Nikos Nikoleris 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in public/gem5[master]: mem-cache: Allow prefetchers to override setCache.

2018-03-06 Thread Gabe Black (Gerrit) 

Hello Xiaoyu Ma,

I'd like you to reexamine a change. Please visit

https://gem5-review.googlesource.com/8701

to look at the new patch set (#2).

Change subject: mem-cache: Allow prefetchers to override setCache.
..

mem-cache: Allow prefetchers to override setCache.

This lets them hook setCache, perhaps to set up additional state based
on the set cache.

Change-Id: Ic3b34fa43d052c71e8ef733a57fe47c70899cd27
---
M src/mem/cache/prefetch/base.hh
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gem5-review.googlesource.com/8701
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ic3b34fa43d052c71e8ef733a57fe47c70899cd27
Gerrit-Change-Number: 8701
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Assignee: Nikos Nikoleris 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Xiaoyu Ma 
Gerit-CC: Andreas Sandberg 
Gerit-CC: Nikos Nikoleris 
Gerrit-MessageType: newpatchset
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev