---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3645/#review8914
---
Any comments? I'm planning on shipping this soon.
- Tony Gutierrez
On Oct. 6, 2016, 4:42 p.m., Tony Gutierrez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3645/
> ---
>
> (Updated Oct. 6, 2016, 4:42 p.m.)
>
>
> Review request for Default.
>
>
> Repository: gem5
>
>
> Description
> ---
>
> Changeset 11671:bd1d5f7f4a29
> ---
> hsail, gpu-compute: remove doGm/SmReturn add completeAcc
>
> we are removing doGmReturn/doSmReturn from the GM/LM pipes respectively,
> and adding completeAcc() implementations for the HSAIL mem ops. the behavior
> in doGmReturn/doSmReturn is dependent on HSAIL and HSAIL mem ops, however the
> completion phase of memory ops in machine ISA can be very different, even
> amongst individual machine ISA mem ops. so we remove this functionality from
> the pipeline and allow it to be implemented by the individual instructions.
>
>
> Diffs
> -
>
> src/gpu-compute/local_memory_pipeline.cc
> 10d59d546ea236b24b8f8261ffa22bfc8a0c736c
> src/gpu-compute/gpu_dyn_inst.cc 10d59d546ea236b24b8f8261ffa22bfc8a0c736c
> src/gpu-compute/local_memory_pipeline.hh
> 10d59d546ea236b24b8f8261ffa22bfc8a0c736c
> src/gpu-compute/gpu_dyn_inst.hh 10d59d546ea236b24b8f8261ffa22bfc8a0c736c
> src/gpu-compute/global_memory_pipeline.hh
> 10d59d546ea236b24b8f8261ffa22bfc8a0c736c
> src/gpu-compute/global_memory_pipeline.cc
> 10d59d546ea236b24b8f8261ffa22bfc8a0c736c
> src/arch/hsail/insts/mem.hh 10d59d546ea236b24b8f8261ffa22bfc8a0c736c
>
> Diff: http://reviews.gem5.org/r/3645/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Tony Gutierrez
>
>
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
