Re: [gem5-dev] Review Request 3650: style: remove err.h to prevent a name collision
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3650/#review8891 --- Ship it! Ship It! - Jason Lowe-Power On Oct. 10, 2016, 5:16 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3650/ > --- > > (Updated Oct. 10, 2016, 5:16 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11672:b10ab7d47bf5 > --- > style: remove err.h to prevent a name collision > > Andreas Sandberg's patch, reviews.gem5.org/r/3648/, exposes a problem. > > Our src/base/misc.hh includes a macro "warn" that redefines the warn > declaration in if src/base/misc.hh is included first before . > The function declaration in gets clobbered by our macro so that the > function is redefined into a form that doesn't work for the header file > declaration. We should really rename our version of "warn" to something > else (and likely the other macros that we have with names like panic and > fatal). This reordering may cause further issues for poorly named macros so > we should discuss this more generally. > > > Diffs > - > > src/base/loader/dtb_object.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > > Diff: http://reviews.gem5.org/r/3650/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3650: style: remove err.h to prevent a name collision
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3650/#review8890 --- Ship it! Ship It! - Tony Gutierrez On Oct. 10, 2016, 10:16 a.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3650/ > --- > > (Updated Oct. 10, 2016, 10:16 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11672:b10ab7d47bf5 > --- > style: remove err.h to prevent a name collision > > Andreas Sandberg's patch, reviews.gem5.org/r/3648/, exposes a problem. > > Our src/base/misc.hh includes a macro "warn" that redefines the warn > declaration in if src/base/misc.hh is included first before . > The function declaration in gets clobbered by our macro so that the > function is redefined into a form that doesn't work for the header file > declaration. We should really rename our version of "warn" to something > else (and likely the other macros that we have with names like panic and > fatal). This reordering may cause further issues for poorly named macros so > we should discuss this more generally. > > > Diffs > - > > src/base/loader/dtb_object.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > > Diff: http://reviews.gem5.org/r/3650/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3650: style: remove err.h to prevent a name collision
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3650/#review8807 --- Ship it! The inclusion of err.h (which is a non-standard BSD extension) seems incorrect. I would argue that this particular name collision is benign since this isn't a standard API. - Andreas Sandberg On Oct. 10, 2016, 6:16 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3650/ > --- > > (Updated Oct. 10, 2016, 6:16 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11672:b10ab7d47bf5 > --- > style: remove err.h to prevent a name collision > > Andreas Sandberg's patch, reviews.gem5.org/r/3648/, exposes a problem. > > Our src/base/misc.hh includes a macro "warn" that redefines the warn > declaration in if src/base/misc.hh is included first before . > The function declaration in gets clobbered by our macro so that the > function is redefined into a form that doesn't work for the header file > declaration. We should really rename our version of "warn" to something > else (and likely the other macros that we have with names like panic and > fatal). This reordering may cause further issues for poorly named macros so > we should discuss this more generally. > > > Diffs > - > > src/base/loader/dtb_object.cc 220fa4099b9a91526b8a1828f27cf1a9f3c15837 > > Diff: http://reviews.gem5.org/r/3650/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
