Re: [gem5-dev] Review Request 3659: stats: Add more information to uninitialized error

2016-10-13 Thread Joe Gross

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3659/#review8841
---

Ship it!


Ship It!

- Joe Gross


On Oct. 11, 2016, 9:45 a.m., Jason Lowe-Power wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3659/
> ---
> 
> (Updated Oct. 11, 2016, 9:45 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> stats: Add more information to uninitialized error
> 
> ClockedObject was changed to require its regStats() to be called from every
> child class. If you forget to do this, the error was indecipherable. This
> patch makes the error more clear.
> 
> 
> Diffs
> -
> 
>   src/base/statistics.cc 220fa4099b9a 
> 
> Diff: http://reviews.gem5.org/r/3659/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lowe-Power
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3659: stats: Add more information to uninitialized error

2016-10-12 Thread Andreas Hansson

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3659/#review8820
---

Ship it!


Ship It!

- Andreas Hansson


On Oct. 11, 2016, 2:45 p.m., Jason Lowe-Power wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3659/
> ---
> 
> (Updated Oct. 11, 2016, 2:45 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> stats: Add more information to uninitialized error
> 
> ClockedObject was changed to require its regStats() to be called from every
> child class. If you forget to do this, the error was indecipherable. This
> patch makes the error more clear.
> 
> 
> Diffs
> -
> 
>   src/base/statistics.cc 220fa4099b9a 
> 
> Diff: http://reviews.gem5.org/r/3659/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jason Lowe-Power
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev