Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/#review8979 --- Ship it! Ship It! - Pierre-Yves Péneau On Oct. 20, 2016, 6:39 p.m.,

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/#review8947 --- Ship it! Ship It! - Anastasiia Butko On Oct. 20, 2016, 4:39 p.m.,

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:39 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/#review8943 --- Ship it! IMO, we don't need the results in the commit message. Unless

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On oct. 18, 2016, 1:55 après-midi, Jason Lowe-Power wrote: > > configs/example/arm/fs_bigLITTLE.py, line 66 > > > > > > Rather than having an extra parameter, could you make a subclass of the > > BigCluster? If this would

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:45 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:35 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:31 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On Oct. 18, 2016, 1:55 p.m., Jason Lowe-Power wrote: > > configs/example/arm/fs_bigLITTLE.py, line 66 > > > > > > Rather than having an extra parameter, could you make a subclass of the > > BigCluster? If this would

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On oct. 18, 2016, 1:55 après-midi, Jason Lowe-Power wrote: > > There are quite a few whitespace errors. Either look at the diff on > > reviewboard to see where the big read boxes are, or run the style checker, > > which should fix them. > > > > Would it make more sense to put the core model

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 19, 2016, 4:22 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On Oct. 18, 2016, 1:55 p.m., Jason Lowe-Power wrote: > > configs/example/arm/fs_bigLITTLE.py, line 70 > > > > > > Why use CpuConfig here? Why not just use ex5_LITTLE.ex5_LITTLE? > > > > I guess this applies to the

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On Oct. 18, 2016, 1:55 p.m., Jason Lowe-Power wrote: > > configs/example/arm/fs_bigLITTLE.py, line 66 > > > > > > Rather than having an extra parameter, could you make a subclass of the > > BigCluster? If this would

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On Oct. 18, 2016, 1:55 p.m., Jason Lowe-Power wrote: > > There are quite a few whitespace errors. Either look at the diff on > > reviewboard to see where the big read boxes are, or run the style checker, > > which should fix them. > > > > Would it make more sense to put the core model

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/#review8889 --- There are quite a few whitespace errors. Either look at the diff on

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

> On oct. 17, 2016, 2:12 après-midi, Jason Lowe-Power wrote: > > The diff doesn't apply correctly. Could you fix and re-upload? I've combined both patches in one. And these changes do not include the MemConfig support. - Anastasiia

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 18, 2016, 4:08 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 18, 2016, 4:04 a.m.) Review request for Default. Summary (updated)