Re: [gem5-dev] Review Request 3747: ruby: Remove RubyMemoryControl and associated files

2016-12-01 Thread Matthew Poremba

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3747/#review9179
---

Ship it!


With this patch I believe we could also remove MemCntrlProfiler.cc/hh as well.

- Matthew Poremba


On Nov. 30, 2016, 4:48 p.m., Andreas Hansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3747/
> ---
> 
> (Updated Nov. 30, 2016, 4:48 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11721:60b44b57fecb
> ---
> ruby: Remove RubyMemoryControl and associated files
> 
> This patch removes the deprecated RubyMemoryControl. The DRAMCtrl
> module should be used instead.
> 
> 
> Diffs
> -
> 
>   src/mem/ruby/structures/RubyMemoryControl.py 482900205561 
>   src/mem/ruby/structures/SConscript 482900205561 
>   src/mem/ruby/structures/RubyMemoryControl.hh 482900205561 
>   src/mem/ruby/structures/RubyMemoryControl.cc 482900205561 
>   src/mem/ruby/structures/MemoryNode.hh 482900205561 
>   src/mem/ruby/structures/MemoryNode.cc 482900205561 
>   src/mem/ruby/SConscript 482900205561 
> 
> Diff: http://reviews.gem5.org/r/3747/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request 3747: ruby: Remove RubyMemoryControl and associated files

2016-11-30 Thread Jason Lowe-Power

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3747/#review9177
---

Ship it!


Ship It!

- Jason Lowe-Power


On Nov. 30, 2016, 4:48 p.m., Andreas Hansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3747/
> ---
> 
> (Updated Nov. 30, 2016, 4:48 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11721:60b44b57fecb
> ---
> ruby: Remove RubyMemoryControl and associated files
> 
> This patch removes the deprecated RubyMemoryControl. The DRAMCtrl
> module should be used instead.
> 
> 
> Diffs
> -
> 
>   src/mem/ruby/structures/RubyMemoryControl.py 482900205561 
>   src/mem/ruby/structures/SConscript 482900205561 
>   src/mem/ruby/structures/RubyMemoryControl.hh 482900205561 
>   src/mem/ruby/structures/RubyMemoryControl.cc 482900205561 
>   src/mem/ruby/structures/MemoryNode.hh 482900205561 
>   src/mem/ruby/structures/MemoryNode.cc 482900205561 
>   src/mem/ruby/SConscript 482900205561 
> 
> Diff: http://reviews.gem5.org/r/3747/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev