----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/737/#review1300 -----------------------------------------------------------
Ship it! - Steve On 2011-06-07 02:24:01, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/737/ > ----------------------------------------------------------- > > (Updated 2011-06-07 02:24:01) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ISA parser: Loosen the regular expressions matching filenames. > > The regular expressions matching filenames in the ##include directives and the > internally generated ##newfile directives where only looking for filenames > composed of alpha numeric characters, periods, and dashes. In Unix/Linux, the > rules for what characters can be in a filename are much looser than that. This > change replaces those expressions with ones that look for anything other than > a quote character. Technically quote characters are allowed as well so we > should allow escaping them somehow, but the additional complexity probably > isn't worth it. > > > Diffs > ----- > > src/arch/isa_parser.py 4d1005f78496 > > Diff: http://reviews.m5sim.org/r/737/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list gem5-dev@m5sim.org http://m5sim.org/mailman/listinfo/gem5-dev
