Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-06-13 Thread Gabe Black
On 06/12/11 16:29, Steve Reinhardt wrote: On Sun, Jun 12, 2011 at 1:05 AM, Gabe Black gbl...@eecs.umich.edu wrote: I was thinking about this today, and if we expand the read/write functions to handle signed types too, we're really just expanding the arbitrary set of types they can handle, not

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-06-12 Thread Gabe Black
On 06/04/11 09:32, Steve Reinhardt wrote: On Sat, Jun 4, 2011 at 1:57 AM, Gabe Black gbl...@eecs.umich.edu wrote: To clarify, is this signed/unsigned issue something we need to deal with before this patch goes in, or can it be dealt with separately later? I'd like to see it handled before the

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-06-12 Thread Steve Reinhardt
On Sun, Jun 12, 2011 at 1:05 AM, Gabe Black gbl...@eecs.umich.edu wrote: I was thinking about this today, and if we expand the read/write functions to handle signed types too, we're really just expanding the arbitrary set of types they can handle, not removing the limitation that you have to

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-06-04 Thread Gabe Black
On 05/31/11 00:13, Gabe Black wrote: On 05/30/11 21:57, Steve Reinhardt wrote: On Mon, May 30, 2011 at 1:33 PM, Gabe Black gbl...@eecs.umich.edu wrote: On 05/30/11 09:47, Steve Reinhardt wrote: Anyway, it seems very odd to have to say (int8_t)Mem.ub when we already have a .sb operand type

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-06-04 Thread Steve Reinhardt
On Sat, Jun 4, 2011 at 1:57 AM, Gabe Black gbl...@eecs.umich.edu wrote: To clarify, is this signed/unsigned issue something we need to deal with before this patch goes in, or can it be dealt with separately later? I'd like to see it handled before the patch is committed, mostly because I'm

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-05-31 Thread Gabe Black
On 05/30/11 21:57, Steve Reinhardt wrote: On Mon, May 30, 2011 at 1:33 PM, Gabe Black gbl...@eecs.umich.edu wrote: On 05/30/11 09:47, Steve Reinhardt wrote: Anyway, it seems very odd to have to say (int8_t)Mem.ub when we already have a .sb operand type defined as int8_t. It seems like a

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-05-30 Thread Gabe Black
On 2011-05-28 21:58:27, Steve Reinhardt wrote: The description is a little general; can you be more specific about what this change is doing? I see that you're getting rid of the size from the memory access operands and encoding that in the ctype instead, which seems fine. However

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-05-30 Thread Gabe Black
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/655/ --- (Updated 2011-05-30 00:18:31.344077) Review request for Default, Ali Saidi, Gabe

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-05-30 Thread Steve Reinhardt
On 2011-05-28 21:58:27, Steve Reinhardt wrote: The description is a little general; can you be more specific about what this change is doing? I see that you're getting rid of the size from the memory access operands and encoding that in the ctype instead, which seems fine. However

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-05-30 Thread Gabe Black
On 05/30/11 09:47, Steve Reinhardt wrote: On 2011-05-28 21:58:27, Steve Reinhardt wrote: The description is a little general; can you be more specific about what this change is doing? I see that you're getting rid of the size from the memory access operands and encoding that in the ctype

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-05-30 Thread Steve Reinhardt
On Mon, May 30, 2011 at 1:33 PM, Gabe Black gbl...@eecs.umich.edu wrote: On 05/30/11 09:47, Steve Reinhardt wrote: Anyway, it seems very odd to have to say (int8_t)Mem.ub when we already have a .sb operand type defined as int8_t.  It seems like a weird hidden restriction to say that there

Re: [gem5-dev] Review Request: ISA parser: Simplify operand type handling.

2011-05-28 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/655/#review1276 --- The description is a little general; can you be more specific about what