Re: [gem5-dev] Review Request: Loader: Handle bad section names when loading an ELF file.

2011-06-12 Thread Steve Reinhardt

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/736/#review1325
---

Ship it!


- Steve


On 2011-06-04 11:42:05, Gabe Black wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/736/
> ---
> 
> (Updated 2011-06-04 11:42:05)
> 
> 
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
> 
> 
> Summary
> ---
> 
> Loader: Handle bad section names when loading an ELF file.
> 
> If there's a problem when reading the section names from a supposed ELF file,
> this change makes gem5 print an error message as returned by libelf and die.
> Previously these sorts of errors would make gem5 segfault when it tried to
> access the section name through a NULL pointer.
> 
> 
> Diffs
> -
> 
>   src/base/loader/elf_object.cc b9ba22cb23f2 
> 
> Diff: http://reviews.m5sim.org/r/736/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabe
> 
>

___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Review Request: Loader: Handle bad section names when loading an ELF file.

2011-06-12 Thread Gabe Black
Ping

On 06/04/11 11:42, Gabe Black wrote:
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/736/
> ---
>
> Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and 
> Nathan Binkert.
>
>
> Summary
> ---
>
> Loader: Handle bad section names when loading an ELF file.
>
> If there's a problem when reading the section names from a supposed ELF file,
> this change makes gem5 print an error message as returned by libelf and die.
> Previously these sorts of errors would make gem5 segfault when it tried to
> access the section name through a NULL pointer.
>
>
> Diffs
> -
>
>   src/base/loader/elf_object.cc b9ba22cb23f2 
>
> Diff: http://reviews.m5sim.org/r/736/diff
>
>
> Testing
> ---
>
>
> Thanks,
>
> Gabe
>
> ___
> gem5-dev mailing list
> gem5-dev@m5sim.org
> http://m5sim.org/mailman/listinfo/gem5-dev

___
gem5-dev mailing list
gem5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/gem5-dev