Re: [m5-dev] Review Request: Ruby: Fix DPRINTF bugs in PerfectSwitch and MessageBuffer

2011-03-01 Thread Brad Beckmann 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/505/#review921
---

Ship it!


- Brad


On 2011-03-01 13:31:45, Nilay Vaish wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/505/
 ---
 
 (Updated 2011-03-01 13:31:45)
 
 
 Review request for Default.
 
 
 Summary
 ---
 
 At a couple of places in PerfectSwitch.cc and MessageBuffer.cc, DPRINTF()
 has not been provided with correct number of arguments. The patch fixes these
 bugs.
 
 
 Diffs
 -
 
   src/mem/ruby/buffers/MessageBuffer.cc UNKNOWN 
   src/mem/ruby/network/simple/PerfectSwitch.cc UNKNOWN 
 
 Diff: http://reviews.m5sim.org/r/505/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Nilay
 


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: Ruby: Fix DPRINTF bugs in PerfectSwitch and MessageBuffer

2011-03-01 Thread Beckmann, Brad 
Hi Nilay,

In the future, feel free to directly check in these sort of minor bug fixes.

Thanks,

Brad


 -Original Message-
 From: m5-dev-boun...@m5sim.org [mailto:m5-dev-boun...@m5sim.org]
 On Behalf Of Nilay Vaish
 Sent: Tuesday, March 01, 2011 1:32 PM
 To: Nilay Vaish; Default
 Subject: [m5-dev] Review Request: Ruby: Fix DPRINTF bugs in PerfectSwitch
 and MessageBuffer
 
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://reviews.m5sim.org/r/505/
 ---
 
 Review request for Default.
 
 
 Summary
 ---
 
 At a couple of places in PerfectSwitch.cc and MessageBuffer.cc, DPRINTF()
 has not been provided with correct number of arguments. The patch fixes
 these bugs.
 
 
 Diffs
 -
 
   src/mem/ruby/buffers/MessageBuffer.cc UNKNOWN
   src/mem/ruby/network/simple/PerfectSwitch.cc UNKNOWN
 
 Diff: http://reviews.m5sim.org/r/505/diff
 
 
 Testing
 ---
 
 
 Thanks,
 
 Nilay
 
 ___
 m5-dev mailing list
 m5-dev@m5sim.org
 http://m5sim.org/mailman/listinfo/m5-dev


___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev