Re: [m5-dev] Review Request: sim: use nextCycle() for quiesceSkip function

2011-03-25 Thread Korey Sewell
/**  * Clock cycle count type.  * @note using an unsigned breaks the cache.  */ typedef int64_t Tick; though offhand I'm not sure why that's true.  I just grepped through the code and it looks like there are places where the code subtracts two tick values and may expect the difference to

Re: [m5-dev] Review Request: sim: use nextCycle() for quiesceSkip function

2011-03-23 Thread Steve Reinhardt
base/types.hh says: /** * Clock cycle count type. * @note using an unsigned breaks the cache. */ typedef int64_t Tick; though offhand I'm not sure why that's true. I just grepped through the code and it looks like there are places where the code subtracts two tick values and may expect the

Re: [m5-dev] Review Request: sim: use nextCycle() for quiesceSkip function

2011-03-21 Thread Korey Sewell
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/603/#review1002 --- src/sim/pseudo_inst.cc http://reviews.m5sim.org/r/603/#comment1370

Re: [m5-dev] Review Request: sim: use nextCycle() for quiesceSkip function

2011-03-21 Thread Ali Saidi
What is the exact problem you're trying to solve here? Why can the compiler complain about this? What is the error message? Ali Sent from my ARM powered device On Mar 20, 2011, at 8:14 PM, Korey Sewell ksew...@umich.edu wrote: ---

Re: [m5-dev] Review Request: sim: use nextCycle() for quiesceSkip function

2011-03-21 Thread Korey Sewell
Sorry, I didnt give the full details here. I'm using gcc4.4.1. And when I compile for m5.opt/debug then I get the following errors: [ CXX] ALPHA_FS_MOESI_CMP_directory/sim/pseudo_inst.cc - .o ... cc1plus: warnings being treated as errors build/ALPHA_FS_MOESI_CMP_directory/sim/eventq.hh: In

Re: [m5-dev] Review Request: sim: use nextCycle() for quiesceSkip function

2011-03-21 Thread Gabriel Michael Black
This looks like the compiler being a little over ambitious looking for problems. Can we just turn off that warning? Gabe Quoting Korey Sewell ksew...@umich.edu: Sorry, I didnt give the full details here. I'm using gcc4.4.1. And when I compile for m5.opt/debug then I get the following

Re: [m5-dev] Review Request: sim: use nextCycle() for quiesceSkip function

2011-03-21 Thread Gabriel Michael Black
I just saw Ali's email (casting to UTick). I like that idea better than mine. I had just assumed Tick already was unsigned, but apparently that's not true. Gabe Quoting Gabriel Michael Black gbl...@eecs.umich.edu: This looks like the compiler being a little over ambitious looking for