[Gen-art] Genart last call review of draft-ietf-core-object-security-14

[Joel Halpern]

Reviewer: Joel Halpern
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

.

Document: draft-ietf-core-object-security-14
Reviewer: Joel Halpern
Review Date: 2018-07-26
IETF LC End Date: 2018-07-30
IESG Telechat date: Not scheduled for a telechat

Summary: This document is ready for publication as a Proposed Standqrd RFC
My thanks to the authors for addressing my minor concerns.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:  N/A


___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

[Gen-art] Genart telechat review of draft-ietf-dnsop-session-signal-12

[Joel Halpern]

Reviewer: Joel Halpern
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

.

Document: draft-ietf-dnsop-session-signal-12
Reviewer: Joel Halpern
Review Date: 2018-07-26
IETF LC End Date: 2018-06-25
IESG Telechat date: 2018-08-02

Summary: This document is ready for publication as a Proposed Standard
My thanks to the authors and working group for addressing my comments.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:  N/A


___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

[Gen-art] Review Assignments

[Jean Mahoney]

Hi all,

The following reviewers have assignments:

For telechat 2018-08-02

Reviewer   Type  LC end Draft
Elwyn Davies   Telechat  2018-02-26 
draft-ietf-anima-autonomic-control-plane-16 *
Wassim Haddad  Telechat  2018-05-21 draft-ietf-v6ops-conditional-ras-05 
*
Joel Halpern   Telechat  2018-06-25 draft-ietf-dnsop-session-signal-12 *
Pete Resnick   Telechat  2018-07-13 draft-ietf-extra-imap-objectid-06 *
Robert Sparks  Telechat  2018-06-12 draft-ietf-oauth-device-flow-11 *

Last calls:

Reviewer   Type  LC end Draft
Jari Arkko Last Call 2018-08-06 draft-ietf-oauth-token-exchange-14
Stewart Bryant Last Call 2018-08-08 draft-ietf-doh-dns-over-https-12
Brian CarpenterLast Call 2018-08-08 draft-ietf-sidrops-ov-clarify-03
Joel Halpern   Last Call 2018-07-30 draft-ietf-core-object-security-14 *
Jouni Korhonen Last Call 2018-07-09 draft-ietf-netmod-acl-model-19
Matthew Miller Last Call 2018-07-30 
draft-sahib-451-new-protocol-elements-02
Ines RoblesLast Call 2018-08-13 draft-york-p-charge-info-08
Dale WorleyLast Call 2018-08-08 draft-ietf-acme-acme-13 *
Peter Yee  Last Call 2018-08-03 
draft-ietf-regext-allocation-token-08

* Other revision previously reviewed
** This revision already reviewed

Next in the reviewer rotation:

  Linda Dunbar
  Francis Dupont
  Roni Even
  Tim Evens
  Fernando Gont
  Vijay Gurbani
  Wassim Haddad
  Joel Halpern
  Christer Holmberg
  Russ Housley

The LC and Telechat review templates are included below:
---

-- Begin LC Template --
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

.

Document:
Reviewer:
Review Date:
IETF LC End Date:
IESG Telechat date: (if known)

Summary:

Major issues:

Minor issues:

Nits/editorial comments: 

-- End LC Template --

-- Begin Telechat Template --
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

.

Document:
Reviewer:
Review Date:
IETF LC End Date:
IESG Telechat date: (if known)

Summary:

Major issues:

Minor issues:

Nits/editorial comments:

-- End Telechat Template --


___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] [core] Genart last call review of draft-ietf-core-object-security-13

[Joel M. Halpern]

Thank you.  Those changes nicely address my concerns.
Yours,
Joel

On 7/26/18 2:41 AM, Francesca Palombini wrote:

Hi Joel,

Thanks for your review! I now have updated the draft with improvements from 
your comments, see inline. Hope this clarifies.

Thanks,
Francesca


-Original Message-
From: core  On Behalf Of Joel Halpern
Sent: den 20 juli 2018 04:08
To: gen-art@ietf.org
Cc: draft-ietf-core-object-security@ietf.org; i...@ietf.org; c...@ietf.org
Subject: [core] Genart last call review of draft-ietf-core-object-security-13

Reviewer: Joel Halpern
Review result: Ready

I am the assigned Gen-ART reviewer for this draft. The General Area Review
Team (Gen-ART) reviews all IETF documents being processed by the IESG for
the IETF Chair.  Please treat these comments just like any other last call
comments.

For more information, please see the FAQ at

.

Document: draft-ietf-core-object-security-13
Reviewer: Joel Halpern
Review Date: 2018-07-19
IETF LC End Date: 2018-07-30
IESG Telechat date: Not scheduled for a telechat

Summary: this document is ready for publication as a Proposed Standard
RFC.
 My minor concerns from draft -08 have been addressed.

Major issues: N/A

Minor issues:
 Section 7.2 is about sequence numbers.  The first sentence in 7.2 discusses
 Nonces.  Then the discussion switches to sequence numbers?  My guess is
 that the Nonce is left over from previous text?



Actually, the first sentence discusses nonces since they are constructed from 
Partial IVs, which are basically the Sequence Numbers. I added this precision, 
at the end of the second sentence.

OLD:  An AEAD nonce MUST NOT be used more than once per AEAD key. The 
uniqueness of (key, nonce) pairs is shown in Appendix D.3, and in particular 
depends on a correct usage of Partial IVs.

NEW: An AEAD nonce MUST NOT be used more than once per AEAD key. The uniqueness 
of (key, nonce) pairs is shown in Appendix D.3, and in particular depends on a 
correct usage of Partial IVs (which encode the Sender Sequence Numbers, see 
Section 5).


Nits/editorial comments:
 In the first paragraph of 3.3, the text reads:
   The requirement that Sender ID SHALL be unique in the set of all security
   contexts using the same Master Secret, Master Salt, and ID Context
   guarantees unique (key, nonce) pairs, which avoids nonce reuse.
 Unfortunately, that is not a grammatical sentence.




I think this sentence was too long to be readable, so I tried to split it up. 
Hopefully it makes more sense now.

NEW: This means that Sender ID SHALL be unique in the set of all security 
contexts using the same Master Secret, Master Salt, and ID Context; such a 
requirement guarantees unique (key, nonce) pairs, which avoids nonce reuse.


___
core mailing list
c...@ietf.org
https://www.ietf.org/mailman/listinfo/core


___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] [core] Genart last call review of draft-ietf-core-object-security-13

[Francesca Palombini]

Hi Joel,

Thanks for your review! I now have updated the draft with improvements from 
your comments, see inline. Hope this clarifies.

Thanks,
Francesca

> -Original Message-
> From: core  On Behalf Of Joel Halpern
> Sent: den 20 juli 2018 04:08
> To: gen-art@ietf.org
> Cc: draft-ietf-core-object-security@ietf.org; i...@ietf.org; c...@ietf.org
> Subject: [core] Genart last call review of draft-ietf-core-object-security-13
> 
> Reviewer: Joel Halpern
> Review result: Ready
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area Review
> Team (Gen-ART) reviews all IETF documents being processed by the IESG for
> the IETF Chair.  Please treat these comments just like any other last call
> comments.
> 
> For more information, please see the FAQ at
> 
> .
> 
> Document: draft-ietf-core-object-security-13
> Reviewer: Joel Halpern
> Review Date: 2018-07-19
> IETF LC End Date: 2018-07-30
> IESG Telechat date: Not scheduled for a telechat
> 
> Summary: this document is ready for publication as a Proposed Standard
> RFC.
> My minor concerns from draft -08 have been addressed.
> 
> Major issues: N/A
> 
> Minor issues:
> Section 7.2 is about sequence numbers.  The first sentence in 7.2 
> discusses
> Nonces.  Then the discussion switches to sequence numbers?  My guess is
> that the Nonce is left over from previous text?
> 

Actually, the first sentence discusses nonces since they are constructed from 
Partial IVs, which are basically the Sequence Numbers. I added this precision, 
at the end of the second sentence.

OLD:  An AEAD nonce MUST NOT be used more than once per AEAD key. The 
uniqueness of (key, nonce) pairs is shown in Appendix D.3, and in particular 
depends on a correct usage of Partial IVs.

NEW: An AEAD nonce MUST NOT be used more than once per AEAD key. The uniqueness 
of (key, nonce) pairs is shown in Appendix D.3, and in particular depends on a 
correct usage of Partial IVs (which encode the Sender Sequence Numbers, see 
Section 5).

> Nits/editorial comments:
> In the first paragraph of 3.3, the text reads:
>   The requirement that Sender ID SHALL be unique in the set of all security
>   contexts using the same Master Secret, Master Salt, and ID Context
>   guarantees unique (key, nonce) pairs, which avoids nonce reuse.
> Unfortunately, that is not a grammatical sentence.
> 
> 

I think this sentence was too long to be readable, so I tried to split it up. 
Hopefully it makes more sense now.

NEW: This means that Sender ID SHALL be unique in the set of all security 
contexts using the same Master Secret, Master Salt, and ID Context; such a 
requirement guarantees unique (key, nonce) pairs, which avoids nonce reuse.

> ___
> core mailing list
> c...@ietf.org
> https://www.ietf.org/mailman/listinfo/core

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art