Re: Code guidelines and bash

2014-07-29 Thread 俊平堵
Sun's java code convention (published in year of 97) suggest 80 column per line for old-style terminals. It sounds pretty old, However, I saw some developers (not me :)) like to open multiple terminals in one screen for coding/debugging so 80-colum could be just fit. Google's java convention ( http

Re: Code guidelines and bash

2014-07-29 Thread Andrew Purtell
On Mon, Jul 28, 2014 at 12:05 PM, Doug Cutting wrote: > On Sun, Jul 27, 2014 at 9:28 PM, Ted Dunning > wrote: > > I don't know of any dev environments in common use today that can't > display >100 characters. > > I edit in an 80-column Emacs window that just fits beside an 80-column > shell wind

Re: Code guidelines and bash

2014-07-28 Thread Doug Cutting
On Sun, Jul 27, 2014 at 9:28 PM, Ted Dunning wrote: > I don't know of any dev environments in common use today that can't display > >100 characters. I edit in an 80-column Emacs window that just fits beside an 80-column shell window on a portrait-rotated 24" monitor. Doug

Re: Code guidelines and bash

2014-07-27 Thread Ted Dunning
Indeed. But I, for one, have had more than 80 characters per line ever since I got a vt-100 terminal. I don't know of any dev environments in common use today that can't display >100 characters. Sent from my iPhone > On Jul 27, 2014, at 13:39, Chris Douglas wrote: > > The 80 character limit

Re: Code guidelines and bash

2014-07-27 Thread Chris Douglas
[moving to common-dev@] The 80 character limit is for legibility across dev environments. If it's impeding that goal in bash, then nobody will insist on it. Since HADOOP-9902 rewrites most of this code, the particular cases can be worked through in that JIRA. -C On Sat, Jul 26, 2014 at 12:20 PM,

Re: Code guidelines and bash

2014-07-26 Thread Esteban Gutierrez
Hello Allen, I looked at last patch and personally I don't see any major issue, perhaps JVM flags, URLs and configuration keys might be better to define as environment variables if you want to reduce the length of the lines but I think legibility is more important. cheers, esteban. -- Cloudera,

Re: Code guidelines and bash

2014-07-26 Thread Chris Embree
Allen, et. al., I'm not sure how up to date that checklist is, but imposing such a small size on cmd arguments seems incredibly short sighted. I'm pretty sure that it is not a generally accepted limit. I've seen MANY Hadoop processes require lengthy CLASS_PATHS that were easily over 240 chars.

Re: Code guidelines and bash

2014-07-26 Thread Paresh Yadav
Hey Allen, I am not a shell scripting expert but I have written few and used/seen many from including top 3 enterprise software giants. I don't think everyone sticks to 80 char guidelines, may be this is remnant of the old 80 char terminals. I prefer long descriptive names for the env vars (or var