[VOTE] Release Apache Answer(Incubating) v1.2.0-RC1

2023-11-16 Thread LinkinStar
Hello, This is a call for vote to release Apache Answer(Incubating) version v1.2.0-RC1. The vote thread: https://lists.apache.org/thread/jjcq356m26gvstbo2jbojt42q7t91xyp Vote Result: https://lists.apache.org/thread/z8dgv2wwkwvq53gc7hvv36bcbd5xry49 The release

Re: [VOTE] Release Apache OpenDAL(incubating) v0.42.0-rc.3 - Incubator Vote Round 1

2023-11-16 Thread Justin Mclean
Hi, Sorry, but it -1 binding from me I checked: - incubating in name - signatures and hashes are fine - LICENSE is missing mention of [1]. NOTICE is also incorrect, and would need to include info from The Netty Project NOTICE file. - no unexpected binary files - all source fils have ASF headers

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

2023-11-16 Thread Justin Mclean
Hi, Sorry, but it’s -1 (binding) from me. As I pointed out in my last review, multiple pieces of 3rd party code exist under different licenses, not just one. I suggest you look for copyright statements and work out the 3rd party software and licenses from that. I can see: Copyright (c) 2014

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

2023-11-16 Thread Craig Russell
Hi Zikuan, Just for the record, adding the license *near* the beginning, as was done with yarn-3.4.1.cjs, is perfectly fine. It just needs to be easily found. That is, there is no need for the license to be the first text, as long as it is not after the real content. Warm regards, Craig > On

Re: [VOTE] Release Apache DevLake (Incubating) v0.19.0-rc2

2023-11-16 Thread Zikuan An
Hi Felix, The file config-ui/.yarn/releases/yarn-3.4.1.cjs is used to specify the yarn version and is a generated file. I added the BSD License , but it cannot be added at the beginning