If there are no objections I will cause this vote as passed. IP Clearance is based on lazy consensus. I'll leave this open for another 24 hours just in case anyone wants to vote -1 on this.
On 2024/03/30 00:21:16 Craig Russell wrote: > On Mar 29, 2024, at 10:47, John D. Ament <johndam...@apache.org> wrote: > > > > On Fri, Mar 29, 2024 at 11:13 AM Craig Russell <apache....@gmail.com> wrote: > > > >> I read the IP-Clearance and this seems to be pretty straightforward: > >> > >> The code has already been partly adjusted to use Pekko - > >> https://github.com/pjfanning/aws-spi-pekko-http > >> > >> It is our intention to bring the code in > >> https://github.com/pjfanning/aws-spi-pekko-http into Apache Pekko. The > >> code in that repo is forked from > >> https://github.com/matsluni/aws-spi-akka-http and Matthias Lüneberg has > >> submitted a Software Grant Agreement (SGA) to allow us to use his original > >> commits. > >> > > > > So just to confirm - there's no issue from your perspective that the fork > > predates the SGA? I believe that's my only actual concern, and being able > > to show it clearer is really what I'm trying to say here (but jumping > > straight to how to do it instead of properly conveying the problem I see). > > > > John > > There are no restrictions on the grant. So to me that means that there is no > time box for the grant. The grant should be good before, during, and after > the fork. > > Craig > > > > > > >> > >> The original code written by Matthias Lüneberg was granted to ASF and PJ > >> has forked the project. There are no restrictions in the grant as to what > >> commit is being granted. The entire repository is covered by the grant. > >> > >> I do not see a problem. > >> Craig > >> > >>> On Mar 29, 2024, at 06:42, John D. Ament <johndam...@apache.org> wrote: > >>> > >>> On Fri, Mar 29, 2024 at 9:32 AM PJ Fanning <fannin...@apache.org> wrote: > >>> > >>>> The Software Grant is on file with the ASF Secretary. I don't know > >>>> where these are checked in but the file is referenced in the > >>>> grants.txt in the foundation svn repo. > >>>> > >>>> The template file makes no reference to commit ids. > >>>> > >>>> https://www.apache.org/licenses/software-grant-template.pdf > >>>> > >>>> Matthias has basically given us permission to use his Apache licensed > >>>> code. I am not a lawyer but I think is reasonable to assume that all > >>>> commits to his repo up the SGA date are covered. > >>>> > >>>> I have an iCLA so all my commits to my fork are surely acceptable to the > >>>> ASF? > >>>> > >>>> I don't see why listing commit IDs makes the IP Clearance clearer. I > >>>> can't see commit IDs in any of the cross section of previous clearance > >>>> forms I have seen. > >>>> > >>> > >>> Commit ID is simply one way it's been done. There's a few examples, I'll > >>> list them below. But basically reading your IP form it isn't clear which > >>> repo is actually being brought into Pekko, perhaps a PR would work as > >>> well? There's a couple of examples like that in this list too. Anything > >>> that you feel could be done to make it clearer that it's your repo being > >>> brought in but going through IP Clearance/SGA due to the derived work > >>> clause (otherwise, it's not clear why you as an officer of the foundation > >>> need an IP Clearance to bring in your own work). > >>> > >>> [1]: https://incubator.apache.org/ip-clearance/arrow-datafusion-comet > >>> (Donation PR w/ repo being stood up by us for the target donation) > >>> [2]: > >> https://incubator.apache.org/ip-clearance/daffodil-vscode-debugger.html > >>> (Full original repo and commit ID) > >>> [3]: https://incubator.apache.org/ip-clearance/avro-rust-library.html > >> (Full > >>> original repo and PR) > >>> [4]: https://incubator.apache.org/ip-clearance/tinkerpop-gremlint.html > >>> (Commit ID) > >>> [5]: https://incubator.apache.org/ip-clearance/tika-tika-helm.html (Full > >>> original repo pointer) > >>> [6]: > >>> > >> https://incubator.apache.org/ip-clearance/netbeans-dukescript-presenters.html > >>> (Commit ID and PR) > >>> [7]: https://incubator.apache.org/ip-clearance/pekko-http-cors.html > >>> (Original repo and PR) > >>> > >>> > >>>> > >>>> On Fri, 29 Mar 2024 at 14:19, John D. Ament <johndam...@apache.org> > >> wrote: > >>>>> > >>>>> On Fri, Mar 29, 2024 at 8:34 AM PJ Fanning <fannin...@gmail.com> > >> wrote: > >>>>> > >>>>>> Hi John, > >>>>>> My GitHub repo [1] is a fork of Matthias Lüneberg's repo [2]. His > >>>>>> original repo was built for Akka. My fork modifies it to use Pekko > >>>>>> instead. > >>>>>> So it is my code that is being imported but the SGA is to acknowledge > >>>>>> that the original code was written by Matthias Lüneberg. > >>>>>> We can't bring my fork into Apache Pekko itself without Matthias > >>>>>> Lüneberg's software grant. > >>>>>> > >>>>>> [1] https://github.com/pjfanning/aws-spi-pekko-http > >>>>>> [2] https://github.com/matsluni/aws-spi-akka-http > >>>>> > >>>>> > >>>>> Ok, I see, you previously created a derived work from the original > >>>> author's > >>>>> work, and I'm assuming you approached the author about donating to the > >>>> ASF > >>>>> via SGA which they did so that you can bring the derived work into > >> Pekko. > >>>>> To make that clearer, I would update the IP Clearance to state that the > >>>>> code being imported is from your repo at whatever commit hash which was > >>>>> forked from the original author's work as of whatever commit hash. > >>>>> > >>>>> Was the forked repo's commit hash recorded on the SGA? > >>>>> > >>>>> > >>>>>> > >>>>>> > >>>>>> On Fri, 29 Mar 2024 at 13:14, John D. Ament <johndam...@apache.org> > >>>> wrote: > >>>>>>> > >>>>>>> I’m a little confused. You’re referring to a third party Matthias > >>>>>> Luneberg > >>>>>>> but the code reference is pointing to the officer’s personal GitHub > >>>>>>> account. > >>>>>>> > >>>>>>> Which is being imported? > >>>>>>> > >>>>>>> John > >>>>>>> > >>>>>>> > >>>>>>> On Wed, Mar 27, 2024 at 14:04 PJ Fanning <fannin...@apache.org> > >>>> wrote: > >>>>>>> > >>>>>>>> Hi everyone, > >>>>>>>> > >>>>>>>> Apache Pekko is receiving a donation of an AWS SPI. > >>>>>>>> The AWS SPI is used to make client calls to AWS APIs and is built > >>>>>>>> using Apache Pekko HTTP. We use the AWS SPI in a few of the Apache > >>>>>>>> Pekko Connectors. > >>>>>>>> > >>>>>>>> Please vote to approve this contribution. > >>>>>>>> This is a lazy consensus majority vote, per the IP clearance > >>>> process > >>>>>>>> [2], open for at least 72 hours. > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> PJ > >>>>>>>> > >>>>>>>> [1] > >>>>>>>> > >>>>>> > >>>> https://incubator.apache.org/ip-clearance/pekko-connectors-aws-spi.html > >>>>>>>> [2] https://incubator.apache.org/ip-clearance/ > >>>>>>>> > >>>>>>>> > >>>> --------------------------------------------------------------------- > >>>>>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >>>>>>>> For additional commands, e-mail: general-h...@incubator.apache.org > >>>>>>>> > >>>>>>>> > >>>>>> > >>>>>> --------------------------------------------------------------------- > >>>>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >>>>>> For additional commands, e-mail: general-h...@incubator.apache.org > >>>>>> > >>>>>> > >>>> > >>>> --------------------------------------------------------------------- > >>>> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > >>>> For additional commands, e-mail: general-h...@incubator.apache.org > >>>> > >>>> > >> > >> Craig L Russell > >> c...@apache.org > >> > >> > > Craig L Russell > c...@apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
