Ah yeah, sorry I missed that part, I searched npmjs and found no result so I thought the front end licenses are missing, didn’t notice you used the GitHub address of the dependency. Then only 2 issues need resolved.
> On Jan 31, 2023, at 23:43, Huajie Wang <benj...@apache.org> wrote: > > hi kezhenxu: > > >> All frontend dependencies' licenses are not included in the binary > license file > > I checked again, All frontend dependencies' licenses are already included > in the binary license file[1] (all of them after line 732) > > > [1] > https://github.com/apache/incubator-streampark/blob/dev/dist-material/release-docs/LICENSE#L732 > > > > Best, > Huajie Wang > > > > kezhenxu94 <kezhenx...@apache.org> 于2023年1月31日周二 21:28写道： > >> Hi, it's better you should send a [CANCEL][VOTE] email for the previous >> unsuccessful vote, >> and start a new round of vote with subject [VOTE][ROUND <n>], so people >> won't get confused >> which thread to check. >> >> I'm -1, it looks like not all issues in last round are resolved: >> >> - The maven wrapper license should be included in the source LICENSE >> file[1], >> and should not be included in the binary LICENSE file[2], >> I suggest you don't add unnecessary LICENSE information in binary LICENSE >> if you don't distribute that work >> (maven wrapper is source dependency in this case). >> >> - All frontend dependencies' licenses are not included in the binary >> license file[2], >> although there are some license files copied from the dependencies to the >> licenses folder[3], >> but there are some many other dependencies' license missed in the [2]. >> >> - Some files are copied and modified from other repositories but are not >> listed in the LICENSE file, such as (not curated list) >> - >> streampark-common/src/main/scala/org/apache/streampark/common/util/ExceptionUtils.scala >> is copied and modified from >> https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/util/ExceptionUtils.java >> - >> streampark-common/src/main/scala/org/apache/streampark/common/util/AssertUtils.scala >> is copied and modified from >> https://github.com/spring-projects/spring-framework/blob/main/spring-core/src/main/java/org/springframework/util/Assert.java >> >> Others I checked are OK: >> >> - all tarballs are signed with 5AE01B8E <benj...@apache.org>. >> - all tarballs have correct shasums. >> >> [1] /LICENSE >> [2] dist-material/release-docs/LICENSE >> [3] dist-material/release-docs/licenses/front-end >> >>>> On Jan 31, 2023, at 19:44, Huajie Wang <benj...@apache.org> wrote: >>> >>> Hello Incubator Community: >>> >>> This is a call for a vote to release Apache StreamPark(Incubating) >>> version 2.0.0-RC3 >>> >>> The Apache StreamPark community has voted on and approved a proposal to >>> release >>> Apache StreamPark(Incubating) version 2.0.0-RC3 >>> >>> We now kindly request the Incubator PMC members review and vote on this >>> incubator release. >>> >>> Apache StreamPark, Make stream processing easier! easy-to-use streaming >>> application development framework and operation platform. >>> >>> StreamPark community vote thread: >>> https://lists.apache.org/thread/b3lzmy10tnm1wf0gopskyc93xd3m87zn >>> >>> Vote result thread: >>> https://lists.apache.org/thread/cflr622wv5b262w1tz8myvjr0dcyj8md >>> >>> The release candidate: >>> https://dist.apache.org/repos/dist/dev/incubator/streampark/2.0.0-RC3/ >>> >>> Git tag for the release: >>> https://github.com/apache/incubator-streampark/releases/tag/v2.0.0-rc3 >>> >>> Maven artifacts are available in a staging repository at: >>> >> https://repository.apache.org/content/repositories/orgapachestreampark-1008/ >>> >>> The artifacts signed with PGP key [5AE01B8E], corresponding to [ >>> benj...@apache.org], that can be found in keys file: >>> https://downloads.apache.org/incubator/streampark/KEYS >>> >>> The vote will be open for at least 72 hours or until the necessary number >>> of votes are reached. >>> >>> Please vote accordingly: >>> [ ] +1 approve >>> [ ] +0 no opinion >>> [ ] -1 disapprove with the reason >>> >>> More detailed checklist please refer: >>> • >>> >> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist >>> >>> Steps to validate the release， Please refer to: >>> • https://www.apache.org/info/verification.html >>> • https://streampark.apache.org/community/release/how-to-verify >>> >>> >>> How to Build: >>> >>> 1) clone source code: >>>> git clone -b v2.0.0-rc3 g...@github.com:apache/incubator-streampark.git >>> >>> 2) build project: >>>> cd incubator-streampark && sh ./build.sh >>> >>> >>> Thanks, >>> >>> On behalf of Apache StreamPark(Incubating) community >>> >>> >>> Best, >>> Huajie Wang >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
