and with my +1 the vote passes with: binding +1: - Mark, Jean-Baptiste, Olivier, Jean-Louis, Justin, me
and no -1. I'll promote the binaries now. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> 2015-11-06 8:47 GMT-08:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > Hi Justin, > > thanks, I opened https://issues.apache.org/jira/browse/SIRONA-49 > > also noted the point about git hashes! > > > Romain Manni-Bucau > @rmannibucau <https://twitter.com/rmannibucau> | Blog > <http://rmannibucau.wordpress.com> | Github > <https://github.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Tomitriber > <http://www.tomitribe.com> > > 2015-11-05 20:54 GMT-08:00 Justin Mclean <jus...@classsoftware.com>: > >> Hi, >> >> +1 (binding) but only if you raise a JIRA and fix up LICENSE and NOTICE >> issues for the next release. >> >> Everything here is permissive so it's more a documentation issue than an >> licensing error. >> >> For the next release could you mind mentioning the git/svn hash that the >> released code corresponds to. >> >> I checked: >> - file contains incubating >> - DISCLAIMER exists >> - LICENSE and NOTICE have some issues >> - NOTICE has incorrect year >> - All source file had Apace headers (except a couple of shell scripts) >> - No unexpected binary files >> - Can compile from source >> >> As per [1][2] LICENSE should include: >> - bootstrap (MIT) >> - normalize.css (MIT) >> - datetimepicker (MIT) >> - fontawesome (MIT) >> - font awesome fonts (SIL open font licence) >> - angular (MIT) >> - JQuery (MIT) >> - moment.js (MIT) >> - ng-grid (MIT) >> - RequireJS (MIT or BSD) >> - angular-ui-bootstrap (MIT) >> - jquery.flot (MIT) >> - raphael (MIT or BSD) >> - jquery.tablesorter (MIT) >> - morris.js (BSD) >> - angular-bootstrap-nav-tree (MIT) >> >> I may of missed one or two from a quick glance I took. Basically anything >> that’s MIT or BSD licensed that's bundled in this source release needs to >> be added to LICENSE. [2] None of these need to be mentioned in NOTICE. [3] >> >> Thanks, >> Justin >> >> 1. http://www.apache.org/dev/licensing-howto.html#guiding-principle >> 2. http://www.apache.org/dev/licensing-howto.html#permissive-deps >> 3. http://www.apache.org/dev/licensing-howto.html#mod-notice >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >> >