Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread Kenneth Knowles
I will retract my -1. I need not speak for the others in this thread. If the other IPMC member found and looked at RC2 then by all means proceed. I had guessed that confirming this fact was equivalent to a replacement vote. If not, great! Kenn On Wed, Aug 21, 2019 at 8:31 PM leerho wrote: >

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread leerho
RE: VERIFY VOTE Folks, My apologies, there was an error in the Vote Letter whereby the top of the letter clearly requests a vote on RC2, but down below, the link to the Release Candidate and the GitHub Tag were actually pointing to RC1. Everything else appears to be correct. Please verify that

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread Justin Mclean
Hi, > &^%$%^& You are right. That is a terrible copy/paste error on my part. > However, the top of the vote letter clearly calls out RC2. Are you > changing your vote to -1? If so I will correct the vote letter and we will > have to start over. I think it’s clear enough that it was RC2 that

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread leerho
&^%$%^& You are right. That is a terrible copy/paste error on my part. However, the top of the vote letter clearly calls out RC2. Are you changing your vote to -1? If so I will correct the vote letter and we will have to start over. On Wed, Aug 21, 2019 at 7:08 PM Kenneth Knowles wrote: >

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread Kenneth Knowles
-1 because I did in fact download RC1. I had not noticed, but your call for this vote on general@ links to RC1 artifacts. So the archive of this thread will be confusing if some votes were cast after verifying RC1 while others are corrected. Kenn On Wed, Aug 21, 2019 at 5:20 PM leerho wrote: >

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread Justin Mclean
Hi, > Of all of these, perhaps #4, #6, #7 (perhaps #5) could have the source > license header at the top. Even so, that would be incredibly conservative > and generous. IMO Unless changes are significant I’d leave the original header in there. Up to the PPMC what they think the definition of

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread leerho
Just a guess, did you happen to download RC1 by mistake? Lee. On Wed, Aug 21, 2019 at 5:09 PM leerho wrote: > Kenn, > > I am puzzled by > > I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking >> for a .git directory. > > > The git-commit-id plugin is in a separate

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread leerho
Kenn, I am puzzled by I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking > for a .git directory. The git-commit-id plugin is in a separate "nexus-jars" profile which must be called from the command line. it is specifically placed in the separate profile so that it will

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread leerho
Justin, Thank you for your detailed response! This is very helpful. I will address each one of your license issues: 1. src/main/java/org/apache/datasketches/memory/AccessByteBuffer.java There is only one method (6 lines long) in this entire file that was "adapted" from the the original source

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-21 Thread Kenneth Knowles
+1 Triple-checked: LICENSE, DISCLAIMER, license headers, mvn test I did have to run `mvn -Dmaven.gitcommitid.skip test` since it is looking for a .git directory. On Tue, Aug 20, 2019 at 9:04 PM Justin Mclean wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-20 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes fine - DISCLAIMER exists and uses the WIP text. you also might want to fill in #Podling-Name# - LICENSE is OK. Do you know what is missing? - NOTICE is fine - NO binary files in release - All source files have ASF header -

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-20 Thread William Guo
+1 - code compiles - incubating in name - LICENSE, NOTICE is fine - No unexpected binary files Thanks, William On Tue, Aug 20, 2019 at 10:30 PM Roman Leventov wrote: > +1 > > On Tue, 20 Aug 2019 at 17:05, Furkan KAMACI > wrote: > > > Hi, > > > > +1 from me. > > > > I checked: > > > > -

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-20 Thread Roman Leventov
+1 On Tue, 20 Aug 2019 at 17:05, Furkan KAMACI wrote: > Hi, > > +1 from me. > > I checked: > > - Incubating in name > - LICENSE is fine > - NOTICE is fine > - No unexpected binary files > - Code compiles and tests successfully run > > One objection: DISCLAIMER file should be renamed to

Re: [VOTE] Release 1.1.0-incubating-RC2

2019-08-20 Thread Furkan KAMACI
Hi, +1 from me. I checked: - Incubating in name - LICENSE is fine - NOTICE is fine - No unexpected binary files - Code compiles and tests successfully run One objection: DISCLAIMER file should be renamed to DISCLAIMER-WIP and link at content should point to datasketches. Kind Regards, Furkan

[VOTE] Release 1.1.0-incubating-RC2

2019-08-19 Thread leerho
Hello Apache DataSketches IPMC and Community, 1. This is a call for vote to release Apache DataSketches-memory version: 1.1.0-incubating-RC2 NOTE 1: This is one component of the DataSketches library that provides high-performance access to off-heap memory for Java applications. These are