Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-18 Thread Yi Shen
> > But we can make this page more clearly about the version hint. About the online builder page. Perhaps we can download the source release zip from Apache Server and do unzipping and bundling on the fly in the browser. We can even do sha512 validation in the browser if necessary. On Sat, Nov

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-16 Thread Furkan KAMACI
Hi, +1 from me (binding). I checked: - Incubating in name - DISCLAIMER exists - LICENSE and NOTICE are fine - No unexpected binary files - Checked PGP signatures - Checked Checksums Kind Regards, Furkan KAMACI On Sat, Nov 16, 2019 at 3:55 PM Kevin Ratnasekera wrote: > +1 ( binding ) > > I

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-16 Thread Kevin Ratnasekera
+1 ( binding ) I checked the following. 1. Incubating in name. 2. PGP Signature. 3. SHA512 Checksum. 4. DISCLAIMER exists. 5. LICENSE and NOTICE are fine. Regards On Sat, Nov 16, 2019 at 6:15 PM Sheng Wu wrote: > +1 binding > > ASC checked. > sha512 is there > LICENSE, NOTICE, and DISCLAIMER

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-16 Thread Sheng Wu
+1 binding ASC checked. sha512 is there LICENSE, NOTICE, and DISCLAIMER are right. You should be good to go, now. Good luck. Sheng Wu 吴晟 Twitter, wusheng1108 SHUANG SU 于2019年11月16日周六 下午12:14写道: > Hi > > Just a reminder to vote on the release of Apache ECharts(incubating) 4.5.0, > We have

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-15 Thread SHUANG SU
Hi Just a reminder to vote on the release of Apache ECharts(incubating) 4.5.0, We have got 2 binding vote from Justin and Dave. Still needs few more binding votes to finish the vote. Thanks a lot! -- Su Shuang (100pah) -- On Thu, 14

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-13 Thread Dave Fisher
Carrying over my +1 (binding) from the dev@echarts thread. Regards, Dave Sent from my iPhone > On Nov 11, 2019, at 10:38 AM, SHUANG SU wrote: > > I am pleased to be calling this vote for the release of Apache ECharts > (incubating) 4.5.0 (release candidate 2). > > Apache ECharts community

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-13 Thread Justin Mclean
HI, > Just to clarify, do you mean that we should not make npm option 1. Maybe we > can make building from the source to be option 1 and npm option 2. Does > that work for you? That’s up to you. I suggest you read the policy on releases and do what it suggests. A question may help - where are

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-13 Thread Ovilia
Hi Justin, Just to clarify, do you mean that we should not make npm option 1. Maybe we can make building from the source to be option 1 and npm option 2. Does that work for you? Wenli On Thu, Nov 14, 2019 at 6:06 AM Justin Mclean wrote: > Hi, > > > Most of the JavaScript project fetch

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-13 Thread Justin Mclean
Hi, > Most of the JavaScript project fetch libraries from package manager like > NPM and rare project manually download the source code from SVN. And some > other project like Apache Cordova [4] also use NPM as the primary download > approach. Cordova did have has a history of not compiling with

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-12 Thread SHUANG SU
Hi Justin, Thank you very much for the detailed checking and voting. About the issues you mentioned: > The offical download page [1] says to use nom to install as the first option it probably shouldn’t be doing that. Most of the JavaScript project fetch libraries from package manager like NPM

Re: [VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-11 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes good - DISCLAIMER exists - LICENSE and NOTICE fine - No binary files in release - All source files have ASF headers The offical download page [1] says to use nom to install as the first option it probably shouldn’t be

[VOTE] Release Apache ECharts (incubating) 4.5.0 (release candidate 2)

2019-11-11 Thread SHUANG SU
I am pleased to be calling this vote for the release of Apache ECharts (incubating) 4.5.0 (release candidate 2). Apache ECharts community has voted and approved the release. Vote thread: