Re: Accepting patches in a podling

2010-09-16 Thread Bertrand Delacretaz
On Thu, Sep 16, 2010 at 1:41 AM, Benson Margulies bimargul...@gmail.com wrote: ...It takes about two minutes to make a JIRA. If the contributor can't spare those two minutes, how are they having time to make a patch at all?... ...Perhaps this is because I'm accustomed, at both my day job and

Re: Accepting patches in a podling

2010-09-16 Thread Joe Schaefer
- Original Message From: Bertrand Delacretaz bdelacre...@apache.org To: general@incubator.apache.org Sent: Thu, September 16, 2010 7:40:22 AM Subject: Re: Accepting patches in a podling On Thu, Sep 16, 2010 at 1:41 AM, Benson Margulies bimargul...@gmail.com wrote: ...It takes

Re: Accepting patches in a podling

2010-09-15 Thread Joe Schaefer
- Original Message From: David Lutterkort lut...@redhat.com To: general@incubator.apache.org Sent: Wed, September 15, 2010 7:33:45 PM Subject: Re: Accepting patches in a podling On Tue, 2010-09-14 at 04:22 +0200, Daniel Shahaf wrote: FWIW, what Subversion uses: http

Re: Accepting patches in a podling

2010-09-15 Thread Benson Margulies
This seems a very workable approach - going through Jira for everything is too much work on the part of the contributer. On the one hand, I want to stand off and let any community make its own way within the light constraints of the license policy. On the other hand, I am honestly mystified

Re: Accepting patches in a podling

2010-09-15 Thread David Lutterkort
On Tue, 2010-09-14 at 04:22 +0200, Daniel Shahaf wrote: FWIW, what Subversion uses: http://subversion.apache.org/docs/community-guide/community-guide.html#patches http://subversion.apache.org/docs/community-guide/community-guide.html#patch-manager Briefly, all patches go to dev@, and only

Re: Accepting patches in a podling

2010-09-15 Thread Craig L Russell
On Sep 15, 2010, at 4:41 PM, Joe Schaefer wrote: - Original Message From: David Lutterkort lut...@redhat.com To: general@incubator.apache.org Sent: Wed, September 15, 2010 7:33:45 PM Subject: Re: Accepting patches in a podling On Tue, 2010-09-14 at 04:22 +0200, Daniel Shahaf wrote

Re: Accepting patches in a podling

2010-09-15 Thread Joe Schaefer
- Original Message From: Craig L Russell craig.russ...@oracle.com To: general@incubator.apache.org Sent: Wed, September 15, 2010 8:05:01 PM Subject: Re: Accepting patches in a podling On Sep 15, 2010, at 4:41 PM, Joe Schaefer wrote: - Original Message From

Re: Accepting patches in a podling

2010-09-15 Thread Upayavira
On Wed, 2010-09-15 at 19:41 -0400, Benson Margulies wrote: This seems a very workable approach - going through Jira for everything is too much work on the part of the contributer. On the one hand, I want to stand off and let any community make its own way within the light

Re: Accepting patches in a podling

2010-09-14 Thread Bertrand Delacretaz
On Tue, Sep 14, 2010 at 2:58 AM, Benson Margulies bimargul...@gmail.com wrote: All patches should be attached to JIRAs with the 'grant' checkbox checked. Only if they are large do you then have to contemplate asking for a CLA and going through the clearance process. Or so I understand it.

Accepting patches in a podling

2010-09-13 Thread David Lutterkort
What is the offical process for accepting patches from non-comitters in a podling ? Is it enough to insist that contributors that are not committers have a CLA on file or do I also have to make them file each patch in jira ? David

Re: Accepting patches in a podling

2010-09-13 Thread Benson Margulies
All patches should be attached to JIRAs with the 'grant' checkbox checked. Only if they are large do you then have to contemplate asking for a CLA and going through the clearance process. Or so I understand it. On Mon, Sep 13, 2010 at 8:55 PM, David Lutterkort lut...@redhat.com wrote: What is

Re: Accepting patches in a podling

2010-09-13 Thread Davanum Srinivas
David, Yes, current practice is exactly what Benson outlined. thanks, dims On 09/13/2010 08:58 PM, Benson Margulies wrote: All patches should be attached to JIRAs with the 'grant' checkbox checked. Only if they are large do you then have to contemplate asking for a CLA and going through the

Re: Accepting patches in a podling

2010-09-13 Thread Daniel Shahaf
So each patch /must/ go via JIRA and get some checkbox filled? Seriously? 1. Over at Subversion, the practice has been to just say thankyou and commit the patches. A few times, with large-scale contributions (eg: someone sent us an SQL backend), we have required filing an ICLA first --- but that

Re: Accepting patches in a podling

2010-09-13 Thread Joe Schaefer
...@daniel.shahaf.name To: general@incubator.apache.org Sent: Mon, September 13, 2010 9:43:09 PM Subject: Re: Accepting patches in a podling So each patch /must/ go via JIRA and get some checkbox filled? Seriously? 1. Over at Subversion, the practice has been to just say thankyou and commit

Re: Accepting patches in a podling

2010-09-13 Thread Benson Margulies
it is not a good thing. - Original Message From: Daniel Shahaf d...@daniel.shahaf.name To: general@incubator.apache.org Sent: Mon, September 13, 2010 9:43:09 PM Subject: Re: Accepting patches in a podling So each patch /must/ go via JIRA and get some checkbox filled

Re: Accepting patches in a podling

2010-09-13 Thread Benson Margulies
email to a committer who commits it is not a good thing. - Original Message From: Daniel Shahaf d...@daniel.shahaf.name To: general@incubator.apache.org Sent: Mon, September 13, 2010 9:43:09 PM Subject: Re: Accepting patches in a podling So each patch /must/ go via JIRA

Re: Accepting patches in a podling

2010-09-13 Thread Daniel Shahaf
Benson Margulies wrote on Mon, Sep 13, 2010 at 22:03:12 -0400: However, I thank Joe for pointing out that I was careful to avoid stating a requirement when I didn't know that one existed. Thanks for clarifying. To summarize, having all patches go via JIRA is one possible way of working, but

Re: Accepting patches in a podling

2010-09-13 Thread Daniel Shahaf
, September 13, 2010 9:43:09 PM Subject: Re: Accepting patches in a podling So each patch /must/ go via JIRA and get some checkbox filled? Seriously? 1. Over at Subversion, the practice has been to just say thankyou and commit the patches. A few times, with large-scale contributions